Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: correctly format compilation errors for Webpack 5 #164

Merged
merged 3 commits into from
Jul 26, 2020

Conversation

pmmmwh
Copy link
Owner

@pmmmwh pmmmwh commented Jul 26, 2020

Since Webpack 5 changes how compilation stats for errors and warnings are emitted (as an object instead of a concatenated string), we need to update our error formatter to allow errors to be displayed correctly.

Before

Screenshot 2020-07-26 at 12 11 48 PM

After

Screenshot 2020-07-26 at 12 13 21 PM

@pmmmwh pmmmwh added the bug Something isn't working label Jul 26, 2020
@pmmmwh pmmmwh self-assigned this Jul 26, 2020
@pmmmwh pmmmwh merged commit 60881b6 into main Jul 26, 2020
@pmmmwh pmmmwh deleted the feat/webpack-5-errors branch July 26, 2020 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant