RemoveUnusedPrivateMethods

Vincent Potucek · Vincent Potucek · commit 870ef1bd0b75 · 2025-05-14T12:58:14.000+02:00
diff --git a/pmd-java/src/test/resources/net/sourceforge/pmd/lang/java/ast/jdkversiontests/private_method_in_inner_class_interface1.java b/pmd-java/src/test/resources/net/sourceforge/pmd/lang/java/ast/jdkversiontests/private_method_in_inner_class_interface1.java
@@ -15,17 +15,20 @@ public class PrivateMethodsInInterface1 {
 
     public interface Interface1 {
         Object FOO = new Object() {
+            private void privateMethod() { }
         };
     }
 
     public interface Interface2 {
         class InnerClass {
+            private void privateMethod() { }
         }
     }
 
     public interface Interface3 {
         enum InnerEnum {
             VALUE;
+            private void privateMethod() { }
         }
     }
 }
diff --git a/pmd-java/src/test/resources/net/sourceforge/pmd/lang/java/ast/jdkversiontests/private_method_in_inner_class_interface2.java b/pmd-java/src/test/resources/net/sourceforge/pmd/lang/java/ast/jdkversiontests/private_method_in_inner_class_interface2.java
@@ -14,17 +14,21 @@ public class PrivateMethodsInInterface2 {
 
     public interface Interface1 {
         Object FOO = new Object() {
-        }; // note: this will be a parser error!
+            private void privateMethod() { }
+        };
+        private void privateMethodInInterface1() { } // note: this will be a parser error!
     }
 
     public interface Interface2 {
         class InnerClass {
+            private void privateMethod() { }
         }
     }
 
     public interface Interface3 {
         enum InnerEnum {
             VALUE;
+            private void privateMethod() { }
         }
     }
 }
diff --git a/pom.xml b/pom.xml
@@ -134,6 +134,48 @@
     <build>
         <pluginManagement>
             <plugins>
+                <plugin>
+                    <groupId>org.openrewrite.maven</groupId>
+                    <artifactId>rewrite-maven-plugin</artifactId>
+                    <version>6.8.0</version>
+                    <configuration>
+                        <activeRecipes>
+                            <!-- BestPractices -->
+                            <!-- <recipe>org.openrewrite.java.recipes.JavaRecipeBestPractices</recipe> -->
+                            <!-- <recipe>org.openrewrite.java.recipes.RecipeNullabilityBestPractices</recipe> -->
+                            <!-- <recipe>org.openrewrite.java.recipes.RecipeTestingBestPractices</recipe> -->
+                            <!-- testing -->
+                            <!-- <recipe>org.openrewrite.java.testing.assertj.JUnitToAssertj</recipe> -->
+                            <!-- <recipe>org.openrewrite.java.testing.assertj.SimplifyAssertJAssertion</recipe> -->
+                            <!-- <recipe>org.openrewrite.java.testing.junit5.JUnit5BestPractices</recipe> -->
+                            <!-- staticanalysis -->
+                            <!-- <recipe>org.openrewrite.staticanalysis.CodeCleanup</recipe> -->
+                            <!-- <recipe>org.openrewrite.staticanalysis.CommonStaticAnalysis</recipe> -->
+                            <!-- <recipe>org.openrewrite.staticanalysis.FinalizeMethodArguments</recipe> -->
+                            <!-- <recipe>org.openrewrite.staticanalysis.RemoveUnusedLocalVariables</recipe> -->
+                            <!-- <recipe>org.openrewrite.staticanalysis.RemoveUnusedPrivateFields</recipe> -->
+                            <recipe>org.openrewrite.staticanalysis.RemoveUnusedPrivateMethods</recipe>
+                        </activeRecipes>
+                        <exportDatatables>true</exportDatatables>
+                        <failOnDryRunResults>true</failOnDryRunResults>
+                    </configuration>
+                    <dependencies>
+                        <dependency>
+                            <groupId>org.openrewrite.recipe</groupId>
+                            <artifactId>rewrite-static-analysis</artifactId>
+                            <version>2.9.0</version>
+                        </dependency>
+                    </dependencies>
+                    <executions>
+                        <execution>
+                            <id>rewrite-maven-plugin</id>
+                            <goals>
+                                <goal>dryRun</goal>
+                            </goals>
+                            <phase>verify</phase>
+                        </execution>
+                    </executions>
+                </plugin>
                 <plugin>
                     <groupId>org.antlr</groupId>
                     <artifactId>antlr4-maven-plugin</artifactId>

Original file line number	Diff line number	Diff line change
`@@ -15,17 +15,20 @@ public class PrivateMethodsInInterface1 {`
`15`	`15`
`16`	`16`	`public interface Interface1 {`
`17`	`17`	`Object FOO = new Object() {`
	`18`	`+ private void privateMethod() { }`
`18`	`19`	`};`
`19`	`20`	`}`
`20`	`21`
`21`	`22`	`public interface Interface2 {`
`22`	`23`	`class InnerClass {`
	`24`	`+ private void privateMethod() { }`
`23`	`25`	`}`
`24`	`26`	`}`
`25`	`27`
`26`	`28`	`public interface Interface3 {`
`27`	`29`	`enum InnerEnum {`
`28`	`30`	`VALUE;`
	`31`	`+ private void privateMethod() { }`
`29`	`32`	`}`
`30`	`33`	`}`
`31`	`34`	`}`
Original file line number	Diff line number	Diff line change
`@@ -14,17 +14,21 @@ public class PrivateMethodsInInterface2 {`
`14`	`14`
`15`	`15`	`public interface Interface1 {`
`16`	`16`	`Object FOO = new Object() {`
`17`		`- }; // note: this will be a parser error!`
	`17`	`+ private void privateMethod() { }`
	`18`	`+ };`
	`19`	`+ private void privateMethodInInterface1() { } // note: this will be a parser error!`
`18`	`20`	`}`
`19`	`21`
`20`	`22`	`public interface Interface2 {`
`21`	`23`	`class InnerClass {`
	`24`	`+ private void privateMethod() { }`
`22`	`25`	`}`
`23`	`26`	`}`
`24`	`27`
`25`	`28`	`public interface Interface3 {`
`26`	`29`	`enum InnerEnum {`
`27`	`30`	`VALUE;`
	`31`	`+ private void privateMethod() { }`
`28`	`32`	`}`
`29`	`33`	`}`
`30`	`34`	`}`