-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unable to use Deno inside a components' script tags #32
Comments
Any script using Deno will only work in production when you've run To reiterate though, the adapter can't be used for development... It can only help output files used in production That being said, some more context on what you're trying to do would be helpful as it's likely something unrelated. If you have a repo I could check out, I'd be happy to take a look! |
To add a little bit to what @brocococonut mentioned, this might change in the future, with the recent stabilization of npm support in Deno, and in particular with them getting Vite successfully running in Deno: Both should make it possible to run the end-to-end development process using Deno, but that is of a wider scope than what I had planned for this adapter. Related discussion in the past: #6 |
Has your stance on this changed somewhat? I see the repo description now says “A SvelteKit adapter for Deno”, with a tag to match 😉 |
@erlend-sh now that the Deno team have managed to get Vite itself running under Deno's compatibility layer for Node, I think it's worth trying to get the whole thing running end-to-end in Deno, yes. However, that may not necessarily result in any changes to this adapter specifically, as it is still "only" a SvelteKit adapter, and as such is Node-first. For example, when using the adapters for Cloudflare, Vercel, Netlify, etc., the development experience doesn't change, |
So how do we get it sveltekit and deno running during live development now that vite works with deno? |
@jakubdonovan after the architecture changes a few months ago, SvelteKit is now "just" a Vite plugin , so in theory if Vite runs fine under Deno, then you should just be able to run it with the SvelteKit plugin and it should work end-to-end in Deno. I haven't tried this myself, but I do want to experiment with that at some point. |
@erlend-sh thank you for the pointer, I'm also tracking that issue and some of the discussion in the Deno Discord, after starting to experiment with SvelteKit on Deno here: https://github.com/jpaquim/sveltekit-deno Unfortunately the patch in my repo still seems to be needed, as the PR mentioned in that issue doesn't seem to have fixed yet. |
produces the following error
I started my development server via
npm run dev
but it looks like it's still running node rather than Deno. Can I get some help?The text was updated successfully, but these errors were encountered: