Aligns cli syntax for extra_arguments #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, using extra_arguments from the cli required passing arguments like so: `--content_source <foo>` The internal underscore makes this unlike other cli opts. This patch replaces internal hyphens with an underscore, so extra_arguments can now be passed the same as normal cli opts: `--content-source <foo>` Fixes #164
Codecov Report
@@ Coverage Diff @@
## develop #174 +/- ##
========================================
Coverage 18.88% 18.88%
========================================
Files 14 14
Lines 768 768
Branches 81 81
========================================
Hits 145 145
Misses 622 622
Partials 1 1
Continue to review full report at Codecov.
|
KevinPlus3
approved these changes
Mar 8, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, using extra_arguments from the cli required passing
arguments like so:
--content_source <foo>The internal underscore makes this unlike other cli opts.
This patch replaces internal hyphens with an underscore, so
extra_arguments can now be passed the same as normal cli opts:
--content-source <foo>Fixes #164