Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display of ">" character when there are subcategories [V2.12.2] #2424

Closed
phamorais opened this issue Oct 5, 2021 · 14 comments
Closed

Display of ">" character when there are subcategories [V2.12.2] #2424

phamorais opened this issue Oct 5, 2021 · 14 comments
Assignees
Milestone

Comments

@phamorais
Copy link

Hi!
I noticed when using version 2.12.2 and when navigating between the form categories, the GLPI is including " > " to separate the subcategory. (This had already happened in other versions, but I don't remember which one)

image

The correct thing would be to click on a category with a subcategory that the ">" does not appear

gif-subcategoria

@phamorais phamorais changed the title Display of ">" character when there are subcategories Display of ">" character when there are subcategories [V2.12.2] Oct 5, 2021
@btry
Copy link
Collaborator

btry commented Oct 5, 2021

Hi

Do this occur on 2.12.1 as well ?

@phamorais
Copy link
Author

@btry Hi!

It depends on the scenarios.

I have an environment in which I updated from 2.12.1 to 2.12.2, and in this case the error did not happen.

The prints of this issue were applied in an update from version 2.11.2 to version 2.12.2

@btry
Copy link
Collaborator

btry commented Oct 6, 2021

Hi

If I remember well there is a setting in glpi to show the short or long name of a tree item. Maybe this setting is responsible of this behaviour. I'm not sure I can fix it as I rely on glpi to get the item name with its translation, if any.

@phamorais
Copy link
Author

@btry

I'm not aware of this configuration mentioned by you.

Anyway, I reinforce that before version 2.12.2 (without changing any settings in GLPI) the problem did not happen, that is, if I just did an update in the formcreator plugin version, the problem is clearly on the side of Formcreator and not the GLPI.

@Valllium
Copy link

Hi!

I have a similar situation.
glpi 9.5.6
fc 2.12.2

@btry btry self-assigned this Oct 21, 2021
@btry btry added the bug label Oct 21, 2021
@btry
Copy link
Collaborator

btry commented Oct 21, 2021

Hi

I reproduce the issue

@btry
Copy link
Collaborator

btry commented Oct 21, 2021

The problem is very likely caused by this comit in GLPI

glpi-project/glpi@58c9a40

btry added a commit to btry/formcreator that referenced this issue Oct 21, 2021
@btry
Copy link
Collaborator

btry commented Oct 21, 2021

Hi

Please try this fix and feedback.

@Valllium
Copy link

Not help =(

Tried restarting the formcreator plugin, and restarting the server.

err_dropdown

@btry
Copy link
Collaborator

btry commented Oct 22, 2021

Hi

@Valllium : the fix works for me. Check if you have a copy of Formcreator on both glpi/plugins and gpi/marketplace folders. If yes, then you probably patched the wrong copy.

before patch

image

after patch

image

btry added a commit to btry/formcreator that referenced this issue Oct 22, 2021
@Valllium
Copy link

Thanks! Additionally reinstalled the plugin. After the next import of forms from the file, I found that the inheritance of categories is not exported/imported (the category name is summed with the separator '>').

@btry
Copy link
Collaborator

btry commented Oct 22, 2021

So the fix works ?

After the next import of forms from the file, I found that the inheritance of categories is not exported/imported (the category name is summed with the separator '>').

You should maybe open a new issue for that, with a detailed description

@Valllium
Copy link

Yes, the fix works, thank you!

@btry
Copy link
Collaborator

btry commented Oct 22, 2021

Thank you for your feedback, I merge the fix and I close this issue.

@btry btry closed this as completed Oct 22, 2021
@btry btry added this to the 2.12.3 milestone Oct 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants