fix: reset obsoleted tabs

Signed-off-by: Thierry Bugier <[email protected]>

Author: btry

js/scripts.js.php

@@ -813,6 +813,7 @@ function buildTiles(list) {
 
    this.addQuestion = function () {
       var form = $('form[data-itemtype="PluginFormcreatorQuestion"]');
+      var that = this;
       $.ajax({
          url: formcreatorRootDoc + '/ajax/question_add.php',
          type: "POST",
@@ -839,12 +840,14 @@ function buildTiles(list) {
             1
          );
          modalWindow.dialog('close');
+         that.resetTabs();
       });
    }
 
    this.editQuestion = function () {
       var form = $('form[data-itemtype="PluginFormcreatorQuestion"]');
       var questionId = form.find('[name="id"]').val();
+      var that = this;
       $.ajax({
          url: formcreatorRootDoc + '/ajax/question_update.php',
          type: "POST",
@@ -857,12 +860,14 @@ function buildTiles(list) {
          var question = $('.plugin_formcreator_form_design[data-itemtype="PluginFormcreatorForm"] [data-itemtype="PluginFormcreatorQuestion"][data-id="' + questionId + '"]');
          question.find('[data-field="name"]').text(data)
          modalWindow.dialog('close');
+         that.resetTabs();
       });
    }
 
    this.duplicateQuestion = function (target) {
       var item = $(target).closest('.grid-stack-item');
       var id = item.attr('data-id');
+      var that = this;
       if (typeof(id) === 'undefined') {
          return;
       }
@@ -891,6 +896,7 @@ function buildTiles(list) {
             1,
             1
          );
+         that.resetTabs();
       });
    };
 
@@ -945,6 +951,7 @@ function buildTiles(list) {
       if(confirm("<?php echo Toolbox::addslashes_deep(__('Are you sure you want to delete this section?', 'formcreator')); ?> ")) {
          var section = $(item).closest('#plugin_formcreator_form.plugin_formcreator_form_design [data-itemtype="PluginFormcreatorSection"]');
          var sectionId = section.attr('data-id');
+         var that = this;
          $.ajax({
          url: formcreatorRootDoc + '/ajax/section_delete.php',
          type: "POST",
@@ -954,6 +961,7 @@ function buildTiles(list) {
          }).done(function() {
             section.remove();
             plugin_formcreator.updateSectionControls();
+            that.resetTabs();
          }).fail(function(data) {
             alert(data.responseText);
          });
@@ -1005,6 +1013,7 @@ function buildTiles(list) {
    this.duplicateSection = function (item) {
       var section = $(item).closest('#plugin_formcreator_form.plugin_formcreator_form_design [data-itemtype="PluginFormcreatorSection"]');
       var sectionId = section.attr('data-id');
+      var that = this;
       $.ajax({
          url: formcreatorRootDoc + '/ajax/section_duplicate.php',
       type: "POST",
@@ -1018,6 +1027,7 @@ function buildTiles(list) {
          sectionId = $('.plugin_formcreator_form_design[data-itemtype="PluginFormcreatorForm"] [data-itemtype="PluginFormcreatorSection"]').last().attr('data-id');
          plugin_formcreator.initGridStack(sectionId);
          plugin_formcreator.updateSectionControls();
+         that.resetTabs();
       }).fail(function(data) {
          alert(data.responseText);
       });
@@ -1035,6 +1045,7 @@ function buildTiles(list) {
 
    this.addSection = function () {
       var form = $('form[data-itemtype="PluginFormcreatorSection"]');
+      var that = this;
       $.ajax({
          url: formcreatorRootDoc + '/ajax/section_add.php',
          type: "POST",
@@ -1049,12 +1060,14 @@ function buildTiles(list) {
          plugin_formcreator.initGridStack(sectionId);
          plugin_formcreator.updateSectionControls();
          modalWindow.dialog('close');
+         that.resetTabs();
       });
    }
 
    this.editSection = function () {
       var form = $('form[data-itemtype="PluginFormcreatorSection"]');
       var sectionId = form.find('[name="id"]').val();
+      var that = this;
       $.ajax({
          url: formcreatorRootDoc + '/ajax/section_update.php',
          type: "POST",
@@ -1066,6 +1079,7 @@ function buildTiles(list) {
          var section = $('.plugin_formcreator_form_design[data-itemtype="PluginFormcreatorForm"] [data-itemtype="PluginFormcreatorSection"][data-id="' + sectionId + '"]');
          section.find('> [data-field="name"]').text(data);
          modalWindow.dialog('close');
+         that.resetTabs();
       });
    }
 
@@ -1101,6 +1115,20 @@ function buildTiles(list) {
          }
       );
    }
+
+   /**
+    * Put a spinner inside the given selector
+    */
+   this.showSpinner = function (selector) {
+      return $(selector).html('<img class="plugin_formcreator_spinner" src="../../../pics/spinner.48.gif">');
+   }
+
+   /**
+    * destroy hidden tabs. Useful when their content is obsoleted
+    */
+   this.resetTabs = function () {
+      $('.glpi_tabs [role="tabpanel"][aria-hidden="true"] ').empty();
+   }
 }
 
 // === TARGETS ===