fix: several field have useless slash escaping

Signed-off-by: Thierry Bugier <[email protected]>

Author: btry

inc/field/actorfield.class.php

@@ -217,11 +217,11 @@ public function getValueForTargetText($richText): string {
       $value = [];
       foreach ($this->value as $item) {
          if (filter_var($item, FILTER_VALIDATE_EMAIL) !== false) {
-            $value[] = Toolbox::addslashes_deep($item);
+            $value[] = $item;
          } else {
             $user = new User();
             $user->getFromDB($item);
-            $value[] = Toolbox::addslashes_deep($user->getFriendlyName());
+            $value[] = $user->getFriendlyName();
          }
       }
 

inc/field/datefield.class.php

@@ -117,7 +117,7 @@ public function getValueForDesign(): string {
    }
 
    public function getValueForTargetText($richText): string {
-      return Toolbox::addslashes_deep(Html::convDate($this->value));
+      return Html::convDate($this->value);
    }
 
    public function hasInput($input): bool {

inc/field/datetimefield.class.php

@@ -123,7 +123,7 @@ public function hasInput($input): bool {
    }
 
    public function getValueForTargetText($richText): string {
-      return Toolbox::addslashes_deep(Html::convDateTime($this->value));
+      return Html::convDateTime($this->value);
    }
 
    public function moveUploads() {

inc/field/floatfield.class.php

@@ -126,7 +126,7 @@ public function getValueForDesign(): string {
    }
 
    public function getValueForTargetText($richText): string {
-      return Toolbox::addslashes_deep($this->value);
+      return $this->value;
    }
 
    public function moveUploads() {

inc/field/hiddenfield.class.php

@@ -111,7 +111,7 @@ public static function getName(): string {
    }
 
    public function getValueForTargetText($richText): string {
-      return str_replace("\n", '\r\n', Toolbox::addslashes_deep($this->value));
+      return str_replace("\n", '\r\n', $this->value);
    }
 
    public function hasInput($input): bool {

inc/field/hostnamefield.class.php

@@ -88,7 +88,7 @@ public function getValueForDesign(): string {
    }
 
    public function getValueForTargetText($richText): string {
-      return Toolbox::addslashes_deep($this->value);
+      return $this->value;
    }
 
    public function hasInput($input): bool {

inc/field/ipfield.class.php

@@ -96,7 +96,7 @@ public function getValueForDesign(): string {
    }
 
    public function getValueForTargetText($richText): string {
-      return Toolbox::addslashes_deep($this->value);
+      return $this->value;
    }
 
    public function moveUploads() {

inc/field/tagfield.class.php

@@ -147,7 +147,7 @@ public function getValueForDesign(): string {
 
    public function getValueForTargetText($richText): string {
       $value = Dropdown::getDropdownName(PluginTagTag::getTable(), $this->value);
-      return Toolbox::addslashes_deep($value);
+      return $value;
    }
 
    public function isValid(): bool {

inc/field/textfield.class.php

@@ -131,7 +131,7 @@ public function getValueForDesign(): string {
    }
 
    public function getValueForTargetText($richText): string {
-      return Toolbox::addslashes_deep($this->value);
+      return $this->value;
    }
 
    public function moveUploads() {

inc/field/timefield.class.php

@@ -122,7 +122,7 @@ public function getValueForTargetText($richText): string {
       if ($date === false) {
          return ' ';
       }
-      return Toolbox::addslashes_deep($date->format('H:i'));
+      return $date->format('H:i');
    }
 
    public function moveUploads() {