fix(requesttypefield): warning if comparing against empty value

pluginsGLPI · Oct 7, 2022 · dca5afb · dca5afb
1 parent fa6a360
commit dca5afb
Showing 1 changed file with 14 additions and 0 deletions.
diff --git a/inc/field/requesttypefield.class.php b/inc/field/requesttypefield.class.php
@@ -174,19 +174,33 @@ public function isValidValue($value): bool {
 
    public function equals($value): bool {
       $available = $this->getAvailableValues();
+      if (!isset($available[$this->value])) {
+         return false;
+      }
       return strcasecmp($available[$this->value], $value) === 0;
    }
 
    public function notEquals($value): bool {
+      $available = $this->getAvailableValues();
+      if (!isset($available[$this->value])) {
+         return false;
+      }
       return !$this->equals($value);
    }
 
    public function greaterThan($value): bool {
       $available = $this->getAvailableValues();
+      if (!isset($available[$this->value])) {
+         return false;
+      }
       return strcasecmp($available[$this->value], $value) > 0;
    }
 
    public function lessThan($value): bool {
+      $available = $this->getAvailableValues();
+      if (!isset($available[$this->value])) {
+         return false;
+      }
       return !$this->greaterThan($value) && !$this->equals($value);
    }