fix(install): prevent fatal error in migration

pluginsGLPI · May 26, 2023 · b0b1571 · b0b1571
1 parent bc255ab
commit b0b1571
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/install/install.php b/install/install.php
@@ -143,6 +143,7 @@ public function upgrade(Migration $migration, $args = []): bool {
          }
       }
 
+      $this->migration = $migration;
       $oldVersion = Config::getConfigurationValue('formcreator', 'previous_version');
       // Force fix of signed columns to reduce upgrade errors frequency
       // This assumes that all modified columns exist in the database
@@ -185,7 +186,6 @@ public function upgrade(Migration $migration, $args = []): bool {
          }
       }
 
-      $this->migration = $migration;
       if (isset($args['force-upgrade']) && $args['force-upgrade'] === true) {
          // Might return false
          $fromSchemaVersion = array_search(PLUGIN_FORMCREATOR_SCHEMA_VERSION, $this->upgradeSteps);
@@ -1024,5 +1024,7 @@ protected function migrateFkToUnsignedInt() {
          }
          $this->migration->changeField($table, 'id', 'id', 'int ' . DBConnection::getDefaultPrimaryKeySignOption() . ' not null auto_increment');
       }
+
+      $this->migration->executeMigration();
    }
 }