fix(section): duplicate form may lead to bad question id in condition

pluginsGLPI · Jun 13, 2023 · a6f9c41 · a6f9c41
1 parent 49f8fc0
commit a6f9c41
Showing 1 changed file with 2 additions and 8 deletions.
diff --git a/inc/condition.class.php b/inc/condition.class.php
@@ -153,14 +153,8 @@ public static function import(PluginFormcreatorLinker $linker, array $input = []
       // set ID for linked objects
       $linked = $linker->getObject($input['plugin_formcreator_questions_id'], PluginFormcreatorQuestion::class);
       if ($linked === false) {
-         $linked = new PluginFormcreatorQuestion();
-         $linked->getFromDBByCrit([
-            $idKey => $input['plugin_formcreator_questions_id']
-         ]);
-         if ($linked->isNewItem()) {
-            $linker->postpone($input[$idKey], $item->getType(), $input, $containerId);
-            return false;
-         }
+         $linker->postpone($input[$idKey], $item->getType(), $input, $containerId);
+         return false;
       }
       /** @var CommonDBTM $linked */
       $input['plugin_formcreator_questions_id'] = $linked->getID();