fix(abstractitiltarget): multiple tag questions set but not displayed…

… in designer
pluginsGLPI · Jan 6, 2023 · 90f2a95 · 90f2a95
1 parent a93f031
commit 90f2a95
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/inc/abstractitiltarget.class.php b/inc/abstractitiltarget.class.php
@@ -1112,7 +1112,7 @@ function change_tag_type() {
                'fieldtype' => ['tag'],
             ],
             '_tag_questions',
-            $this->fields['tag_questions'],
+            explode(',', $this->fields['tag_questions']),
             [
                'multiple' => true,
             ]

diff --git a/inc/question.class.php b/inc/question.class.php
@@ -1043,7 +1043,7 @@ public static function getQuestionsFromFormBySection($form, $crit = []) {
     * @param PluginFormcreatorForm $form
     * @param array $crit
     * @param string $name
-    * @param string $value
+    * @param string|array $value
     * @param array $options
     * @return string|int HTML output or random id
     */
@@ -1055,8 +1055,10 @@ public static function dropdownForForm($form, $crit, $name, $value = null, $opti
       $options = $options + [
          'display' => $options['display'] ?? true,
       ];
-      if ($value !== null) {
+      if (is_string($value)) {
          $options['value'] = $value;
+      } else if (is_array($value)) {
+         $options['values'] = $value;
       }
       $output = Dropdown::showFromArray($name, $items, $options);