Fix graphical glitches when moving between welcome panel, patch view and pluginmode view

Author: timothyschoen

Source/Dialogs/PatchStore.h

@@ -698,6 +698,7 @@ class PatchFullDisplay : public Component, public DownloadPool::DownloadListener
     public:
         enum Type
         {
+            UpdateAvailable,
             AlreadyInstalled,
             Download,
             Store,
@@ -715,7 +716,7 @@ class PatchFullDisplay : public Component, public DownloadPool::DownloadListener
         String getIcon()
         {
             if(type == AlreadyInstalled) return isMouseOver() ? Icons::Reset : Icons::Checkmark;
-            if(type == Download) return Icons::Download;
+            if(type == Download || type == UpdateAvailable) return Icons::Download;
             if(type == Store) return Icons::Store;
             if(type == View) return Icons::Info;
             if(type == Cancel) return {};
@@ -724,6 +725,7 @@ class PatchFullDisplay : public Component, public DownloadPool::DownloadListener
 
         String getText()
         {
+            if(type == UpdateAvailable) return "Update";
             if(type == AlreadyInstalled) return isMouseOver() ? "Reinstall" : "Installed";
             if(type == Download) return "Download";
             if(type == Store) return "View in store";
@@ -866,7 +868,9 @@ class PatchFullDisplay : public Component, public DownloadPool::DownloadListener
 
         auto fileName = URL(currentPatch.download).getFileName();
 
-        if (currentPatch.isPatchInstalled()) {
+        if (currentPatch.updateAvailable()) {
+            downloadButton.setType(LinkButton::UpdateAvailable);
+        } else if (currentPatch.isPatchInstalled()) {
             downloadButton.setType(LinkButton::AlreadyInstalled);
         } else if (currentPatch.isPatchArchive()) {
             downloadButton.setType(LinkButton::Download);
@@ -894,10 +898,8 @@ class PatchFullDisplay : public Component, public DownloadPool::DownloadListener
             }
         }
 
-        if(result.size() <= 1)
+        if(result.size() < 3)
         {
-            result.clear();
-            
             for(auto& [patch, flags] : toFilter)
             {
                 if(result.size() >= 3) break;

Source/NVGSurface.cpp

@@ -130,7 +130,6 @@ void NVGSurface::initialise()
 
     lastRenderScale = calculateRenderScale();
     nvg = nvgCreateContext(view, NVG_ANTIALIAS | NVG_TRIPLE_BUFFER, getWidth() * lastRenderScale, getHeight() * lastRenderScale);
-    resized();
 #else
     setVisible(true);
     glContext->attachTo(*this);
@@ -153,7 +152,6 @@ void NVGSurface::initialise()
     nvgCreateFontMem(nvg, "Inter-SemiBold", (unsigned char*)BinaryData::InterSemiBold_ttf, BinaryData::InterSemiBold_ttfSize, 0);
     nvgCreateFontMem(nvg, "Inter-Tabular", (unsigned char*)BinaryData::InterTabular_ttf, BinaryData::InterTabular_ttfSize, 0);
     nvgCreateFontMem(nvg, "icon_font-Regular", (unsigned char*)BinaryData::IconFont_ttf, BinaryData::IconFont_ttfSize, 0);
-    invalidateAll();
 }
 
 void NVGSurface::updateWindowContextVisibility()
@@ -227,11 +225,6 @@ void NVGSurface::lookAndFeelChanged()
     }
 }
 
-void NVGSurface::triggerRepaint()
-{
-    needsBufferSwap = true;
-}
-
 bool NVGSurface::makeContextActive()
 {
 #ifdef NANOVG_METAL_IMPLEMENTATION
@@ -290,6 +283,8 @@ void NVGSurface::resized()
     }
 #endif
     backupImageComponent.setBounds(editor->getLocalArea(this, getLocalBounds()));
+    invalidateAll();
+    render();
 }
 
 void NVGSurface::invalidateAll()

Source/NVGSurface.h

@@ -41,7 +41,6 @@ class NVGSurface :
 
     void render();
 
-    void triggerRepaint();
     bool makeContextActive();
 
     void detachContext();

Source/PluginEditor.cpp

@@ -516,15 +516,6 @@ CallOutBox& PluginEditor::showCalloutBox(std::unique_ptr<Component> content, Rec
 
 void PluginEditor::showWelcomePanel(bool shouldShow)
 {
-    if(shouldShow)
-    {
-        welcomePanel->show();
-        sidebar->showSidebar(true);
-    }
-    else {
-        welcomePanel->hide();
-    }
-    
     editButton.setVisible(!shouldShow);
     runButton.setVisible(!shouldShow);
     presentButton.setVisible(!shouldShow);
@@ -539,6 +530,15 @@ void PluginEditor::showWelcomePanel(bool shouldShow)
     welcomePanelSearchButton.setVisible(shouldShow);
     recentlyOpenedPanelSelector.setVisible(shouldShow);
     libraryPanelSelector.setVisible(shouldShow);
+    
+    if(shouldShow)
+    {
+        welcomePanel->show();
+        sidebar->showSidebar(true);
+    }
+    else {
+        welcomePanel->hide();
+    }
 }
 
 DragAndDropTarget* PluginEditor::findNextDragAndDropTarget(Point<int> screenPos)

Source/PluginMode.h

@@ -114,7 +114,19 @@ class PluginMode : public Component
         titleBar.addAndMakeVisible(scaleComboBox);
 
         addAndMakeVisible(titleBar);
+        cnv->connectionLayer.setVisible(false);
+    }
 
+    ~PluginMode() override
+    {
+        if (pluginModeLnf) {
+            editor->setLookAndFeel(editor->pd->lnf);
+            editor->getTopLevelComponent()->sendLookAndFeelChange();
+        }
+    }
+        
+    void updateSize()
+    {
         // set scale to the last scale that was set for this patches plugin mode
         // if none was set, use 100% scale
         if (pluginModeScaleMap.contains(patchPtr->getPointer().get())) {
@@ -124,16 +136,6 @@ class PluginMode : public Component
         } else {
             setWidthAndHeight(1.0f);
         }
-
-        cnv->connectionLayer.setVisible(false);
-    }
-
-    ~PluginMode() override
-    {
-        if (pluginModeLnf) {
-            editor->setLookAndFeel(editor->pd->lnf);
-            editor->getTopLevelComponent()->sendLookAndFeelChange();
-        }
     }
 
     void setWidthAndHeight(float scale)
@@ -161,9 +163,8 @@ class PluginMode : public Component
             OSUtils::updateX11Constraints(getPeer()->getNativeHandle());
         }
 #endif
-        editor->setSize(newWidth, newHeight);
         setBounds(0, 0, newWidth, newHeight);
-
+        editor->setSize(newWidth, newHeight);
         editor->nvgSurface.invalidateAll();
     }
 

Source/PluginProcessor.cpp

@@ -635,7 +635,6 @@ void PluginProcessor::processBlock(AudioBuffer<float>& buffer, MidiBuffer& midiB
 
     setThis();
     sendPlayhead();
-    sendParameters();
 
     midiDeviceManager.dequeueMidiInput(buffer.getNumSamples(), [this](int port, int blockSize, MidiBuffer& buffer) {
         midiInputHistory.addEvents(buffer, 0, blockSize, 0);
@@ -915,24 +914,6 @@ void PluginProcessor::sendPlayhead()
     unlockAudioThread();
 }
 
-void PluginProcessor::sendParameters()
-{
-    for (auto* param : getParameters()) {
-        // We used to do dynamic_cast here, but since it gets called very often and param is always PlugDataParameter, we use reinterpret_cast now
-        // this is probably UB...
-        auto* pldParam = reinterpret_cast<PlugDataParameter*>(param);
-        if (!pldParam->isEnabled())
-            continue;
-
-        auto newvalue = pldParam->getUnscaledValue();
-        if (!approximatelyEqual(pldParam->getLastValue(), newvalue)) {
-            auto title = pldParam->getTitle();
-            sendFloat(title.data(), pldParam->getUnscaledValue());
-            pldParam->setLastValue(newvalue);
-        }
-    }
-}
-
 MidiDeviceManager& PluginProcessor::getMidiDeviceManager()
 {
     return midiDeviceManager;

Source/PluginProcessor.h

@@ -126,7 +126,6 @@ class PluginProcessor final : public AudioProcessor
 
     void sendMidiBuffer(int device, MidiBuffer& buffer);
     void sendPlayhead();
-    void sendParameters();
 
     SmallArray<PluginEditor*> getEditors() const;
 

Source/TabComponent.cpp

@@ -381,7 +381,7 @@ void TabComponent::handleAsyncUpdate()
             clearCanvases();
             if (!editor->isInPluginMode() || editor->pluginMode->getPatch()->getPointer().get() != patchInPluginMode->getUncheckedPointer()) {
                 editor->pluginMode = std::make_unique<PluginMode>(editor, patchInPluginMode);
-                editor->resized();
+                editor->pluginMode->updateSize();
                 // hack to force the window title buttons to hide
                 editor->parentSizeChanged();
             }
@@ -772,12 +772,12 @@ void TabComponent::closeTab(Canvas* cnv)
             showTab(tabbars[1][tabbars[1].indexOf(tab) - 1]->cnv, 1);
         }
     }
-
+    
     canvases.removeObject(cnv);
     pd->patches.remove_one(patch);
 
     pd->updateObjectImplementations();
-
+    
     triggerAsyncUpdate();
 }