Skip to content

refactor: Update script to generate schema JSON with 2 space indentation #7626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 24, 2025
+97,859 −97,859
Merged

refactor: Update script to generate schema JSON with 2 space indentation #7626

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
36ec992
Update script to generate schema JSON with 2 space indentation
camdecoster Nov 12, 2025
96e79bc
Add draftlog
camdecoster Nov 13, 2025
f5d2c2d
Merge remote-tracking branch 'origin/master' into cam/7625/update-sch…
camdecoster Nov 24, 2025
b42d995
Rebuild schema after merge
camdecoster Nov 24, 2025
c211fc7
Revert "Add draftlog"
camdecoster Nov 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions draftlogs/7626_change.md
View file
Open in desktop
Copy link
Contributor

@emilykl emilykl Nov 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not totally sure whether we need a draftlog for this, but I don't mind

Copy link
Contributor Author

@camdecoster camdecoster Nov 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I'll drop this one. It's not really necessary.

Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
- Update script to generate schema JSON with 2 space indentation [[#7626](https://github.com/plotly/plotly.js/pull/7626)]
4 changes: 2 additions & 2 deletions tasks/schema.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,8 @@ function makeSchema(plotlyPath, schemaPath) {
const Plotly = plotlyNode(plotlyPath);
const obj = Plotly.PlotSchema.get();
const sortedObj = sortObject(obj);
const plotSchemaRaw = JSON.stringify(obj, null, 1);
const plotSchemaStr = JSON.stringify(sortedObj, null, 1);
const plotSchemaRaw = JSON.stringify(obj, null, 2);
const plotSchemaStr = JSON.stringify(sortedObj, null, 2);

fs.writeFileSync(schemaPath, plotSchemaStr);

Expand Down
Loading