Skip to content

Fix #3022 - validate + polar.bargap #3023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 21, 2018
Merged

Fix #3022 - validate + polar.bargap #3023

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
86e18fb
include 'trace' layout attributes set in subplot containers
etpinard Sep 18, 2018
c5cf89b
make supplyDefault (and Plotly.validate) more strict w/ polar?.bar*
etpinard Sep 21, 2018
1c0d3ed
add deprecation warning to legacy polar charts attr descriptions
etpinard Sep 21, 2018
f32b398
add deprecation warning to area traces attr desciptions
etpinard Sep 21, 2018
019bacf
AJ-proof legacy polar depreaction warnings
etpinard Sep 21, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 20 additions & 5 deletions src/plots/polar/legacy/axis_attributes.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,8 @@ var axesAttrs = require('../../cartesian/layout_attributes');
var extendFlat = require('../../../lib/extend').extendFlat;
var overrideAll = require('../../../plot_api/edit_types').overrideAll;

var deprecationWarning = 'Legacy polar charts are deprecated!';

var domainAttr = extendFlat({}, axesAttrs.domain, {
description: [
'Polar chart subplots are not supported yet.',
Expand All @@ -26,6 +28,7 @@ function mergeAttrs(axisName, nonCommonAttrs) {
valType: 'boolean',
role: 'style',
description: [
deprecationWarning,
'Determines whether or not the line bounding this',
axisName, 'axis',
'will be shown on the figure.'
Expand All @@ -35,6 +38,7 @@ function mergeAttrs(axisName, nonCommonAttrs) {
valType: 'boolean',
role: 'style',
description: [
deprecationWarning,
'Determines whether or not the',
axisName, 'axis ticks',
'will feature tick labels.'
Expand All @@ -45,6 +49,7 @@ function mergeAttrs(axisName, nonCommonAttrs) {
values: ['horizontal', 'vertical'],
role: 'style',
description: [
deprecationWarning,
'Sets the orientation (from the paper perspective)',
'of the', axisName, 'axis tick labels.'
].join(' ')
Expand All @@ -54,31 +59,36 @@ function mergeAttrs(axisName, nonCommonAttrs) {
min: 0,
role: 'style',
description: [
deprecationWarning,
'Sets the length of the tick lines on this', axisName, 'axis.'
].join(' ')
},
tickcolor: {
valType: 'color',
role: 'style',
description: [
deprecationWarning,
'Sets the color of the tick lines on this', axisName, 'axis.'
].join(' ')
},
ticksuffix: {
valType: 'string',
role: 'style',
description: [
deprecationWarning,
'Sets the length of the tick lines on this', axisName, 'axis.'
].join(' ')
},
endpadding: {
valType: 'number',
role: 'style'
role: 'style',
description: deprecationWarning,
},
visible: {
valType: 'boolean',
role: 'info',
description: [
deprecationWarning,
'Determines whether or not this axis will be visible.'
].join(' ')
}
Expand All @@ -97,6 +107,7 @@ module.exports = overrideAll({
{ valType: 'number' }
],
description: [
deprecationWarning,
'Defines the start and end point of this radial axis.'
].join(' ')
},
Expand All @@ -105,6 +116,7 @@ module.exports = overrideAll({
valType: 'number',
role: 'style',
description: [
deprecationWarning,
'Sets the orientation (an angle with respect to the origin)',
'of the radial axis.'
].join(' ')
Expand All @@ -120,6 +132,7 @@ module.exports = overrideAll({
{ valType: 'number', dflt: 360 }
],
description: [
deprecationWarning,
'Defines the start and end point of this angular axis.'
].join(' ')
},
Expand All @@ -133,16 +146,18 @@ module.exports = overrideAll({
values: ['clockwise', 'counterclockwise'],
role: 'info',
description: [
'For polar plots only.',
'Sets the direction corresponding to positive angles.'
deprecationWarning,
'Sets the direction corresponding to positive angles',
'in legacy polar charts.'
].join(' ')
},
orientation: {
valType: 'angle',
role: 'info',
description: [
'For polar plots only.',
'Rotates the entire polar by the given angle.'
deprecationWarning,
'Rotates the entire polar by the given angle',
'in legacy polar charts.'
].join(' ')
}
}
Expand Down