Skip to content

Add null-data buffer fix for parcoords #2612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 22, 2018
Merged

Add null-data buffer fix for parcoords #2612

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
de63951
Add null-data buffer fix
dy May 3, 2018
5d38e88
Add zero arg to TypedArray
dy May 22, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/traces/parcoords/lines.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,7 @@ function setAttributes(attributes, sampleCount, points) {
function emptyAttributes(regl) {
var attributes = {};
for(var i = 0; i < 16; i++) {
attributes['p' + i.toString(16)] = regl.buffer({usage: 'dynamic', type: 'float', data: null});
attributes['p' + i.toString(16)] = regl.buffer({usage: 'dynamic', type: 'float', data: new Uint8Array()});
Copy link
Contributor

@etpinard etpinard May 3, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be new Uint8Array(0) just like you did in:

gl-vis/regl-scatter2d@c1183ef#diff-f0cb24e401db59c6759d5cb577e58cebR403

}
return attributes;
}
Expand Down