Commit d2650fe
committed
resolve #1988 - 🔪 ax._boundingBox (!)
- replace it with getLabelLevelBBox (an extension of getLabelLevelSpan),
to compute axis margin push values. Use cache to not have to compute
the (costly) label bounding boxes unnecessarily
- compute ax._depth during Axes.drawOne, which is the measure in px
between axis position and outward-most part of bounding box,
we use this for (1) multicategory label, (2) axis title and (3)
rangeslider positioning1 parent 9ebbd57 commit d2650fe
File tree
3 files changed
+148
-162
lines changed- src
- components/rangeslider
- plots/cartesian
3 files changed
+148
-162
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
108 | 108 | | |
109 | 109 | | |
110 | 110 | | |
111 | | - | |
112 | 111 | | |
113 | 112 | | |
114 | 113 | | |
115 | 114 | | |
116 | 115 | | |
117 | 116 | | |
118 | 117 | | |
119 | | - | |
| 118 | + | |
120 | 119 | | |
121 | 120 | | |
122 | 121 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
43 | 43 | | |
44 | 44 | | |
45 | 45 | | |
46 | | - | |
47 | | - | |
48 | | - | |
49 | | - | |
| 46 | + | |
50 | 47 | | |
51 | 48 | | |
52 | | - | |
| 49 | + | |
53 | 50 | | |
54 | 51 | | |
55 | 52 | | |
56 | | - | |
| 53 | + | |
57 | 54 | | |
58 | 55 | | |
59 | 56 | | |
0 commit comments