Merge pull request #4273 from plotly/ax-automargin-mirror+free-check

Guard against mirrored+autorange anchor:'free' axes

Author: etpinard

src/plots/cartesian/axes.js

@@ -1942,7 +1942,7 @@ axes.drawOne = function(gd, ax, opts) {
                     ax.title.font.size;
             }
 
-            if(ax.mirror) {
+            if(ax.mirror && ax.anchor !== 'free') {
                 mirrorPush = {x: 0, y: 0, r: 0, l: 0, t: 0, b: 0};
 
                 mirrorPush[sMirror] = ax.linewidth;

src/plots/plots.js

@@ -927,7 +927,7 @@ plots.linkSubplots = function(newFullData, newFullLayout, oldFullData, oldFullLa
         // this loop can be costly, so only compute it when required
         if(ax._counterAxes.length && (
             (ax.spikemode && ax.spikemode.indexOf('across') !== -1) ||
-            (ax.automargin && ax.mirror) ||
+            (ax.automargin && ax.mirror && ax.anchor !== 'free') ||
             Registry.getComponentMethod('rangeslider', 'isVisible')(ax)
         )) {
             var min = 1;

test/jasmine/tests/axes_test.js

@@ -3468,6 +3468,33 @@ describe('Test axes', function() {
             .catch(failTest)
             .then(done);
         });
+
+        it('should handle cases with free+mirror axes', function(done) {
+            Plotly.plot(gd, [{
+                y: [1, 2, 1]
+            }], {
+                xaxis: {
+                    ticks: 'outside',
+                    mirror: 'ticks',
+                    anchor: 'free',
+                    automargin: true
+                },
+                yaxis: {
+                    showline: true,
+                    linewidth: 2,
+                    mirror: 'all',
+                    anchor: 'free',
+                    automargin: true
+                }
+            })
+            .then(function() {
+                // N.B. no '.automargin.mirror'
+                expect(Object.keys(gd._fullLayout._pushmargin))
+                    .toEqual(['x.automargin', 'y.automargin', 'base']);
+            })
+            .catch(failTest)
+            .then(done);
+        });
     });
 
     describe('zeroline visibility logic', function() {

test/jasmine/tests/transition_test.js

@@ -1189,7 +1189,7 @@ describe('Plotly.react transitions:', function() {
         .then(done);
     });
 
-    it('should update ranges of date and category axes', function(done) {
+    it('@flaky should update ranges of date and category axes', function(done) {
         Plotly.plot(gd, [
             {x: ['2018-01-01', '2019-01-01', '2020-01-01'], y: [1, 2, 3]},
             {x: ['a', 'b', 'c'], y: [1, 2, 3], xaxis: 'x2', yaxis: 'y2'}