fixup cmin/cmax -> vertexIntensityBounds

etpinard · etpinard · commit a02dd1148284 · 2018-05-17T12:01:33.000-04:00
diff --git a/src/traces/cone/convert.js b/src/traces/cone/convert.js
@@ -100,7 +100,7 @@ function convert(scene, trace) {
     }
 
     coneOpts.colormap = parseColorScale(trace.colorscale);
-    coneOpts.vertexIntensityBounds = [trace.cmin / trace.cmax, 1];
+    coneOpts.vertexIntensityBounds = [trace.cmin / trace._normMax, trace.cmax / trace._normMax];
 
     coneOpts[sizeMode2sizeKey[trace.sizemode]] = trace.sizeref;
     coneOpts.coneOffset = anchor2coneOffset[trace.anchor];
diff --git a/test/image/baselines/gl3d_cone-wind.png b/test/image/baselines/gl3d_cone-wind.png
diff --git a/test/image/mocks/gl3d_cone-wind.json b/test/image/mocks/gl3d_cone-wind.json
@@ -129166,7 +129166,7 @@
       ],
       "colorscale": "Viridis",
       "cmin": 0,
-      "cmax": 1
+      "cmax": 100,
       "hoverinfo": "u+v+w+text",
       "text": "-> wind <-"
     }

Original file line number	Diff line number	Diff line change
`@@ -100,7 +100,7 @@ function convert(scene, trace) {`
`100`	`100`	`}`
`101`	`101`
`102`	`102`	`coneOpts.colormap = parseColorScale(trace.colorscale);`
`103`		`- coneOpts.vertexIntensityBounds = [trace.cmin / trace.cmax, 1];`
	`103`	`+ coneOpts.vertexIntensityBounds = [trace.cmin / trace._normMax, trace.cmax / trace._normMax];`
`104`	`104`
`105`	`105`	`coneOpts[sizeMode2sizeKey[trace.sizemode]] = trace.sizeref;`
`106`	`106`	`coneOpts.coneOffset = anchor2coneOffset[trace.anchor];`