Merge pull request #3360 from plotly/dont-call-autotype-for-3d

Regression bug fix to draw 3d traces after heatmap

Author: archmoj

src/plots/gl3d/layout/defaults.js

@@ -16,7 +16,9 @@ var Registry = require('../../../registry');
 var handleSubplotDefaults = require('../../subplot_defaults');
 var supplyGl3dAxisLayoutDefaults = require('./axis_defaults');
 var layoutAttributes = require('./layout_attributes');
+var getSubplotData = require('../../get_data').getSubplotData;
 
+var GL3D = 'gl3d';
 
 module.exports = function supplyLayoutDefaults(layoutIn, layoutOut, fullData) {
     var hasNon3D = layoutOut._basePlotModules.length > 1;
@@ -31,7 +33,7 @@ module.exports = function supplyLayoutDefaults(layoutIn, layoutOut, fullData) {
     }
 
     handleSubplotDefaults(layoutIn, layoutOut, fullData, {
-        type: 'gl3d',
+        type: GL3D,
         attributes: layoutAttributes,
         handleDefaults: handleGl3dDefaults,
         fullLayout: layoutOut,
@@ -97,10 +99,12 @@ function handleGl3dDefaults(sceneLayoutIn, sceneLayoutOut, coerce, opts) {
         sceneLayoutIn.aspectmode = sceneLayoutOut.aspectmode;
     }
 
+    var fullGl3dData = getSubplotData(opts.fullData, GL3D, opts.id);
+
     supplyGl3dAxisLayoutDefaults(sceneLayoutIn, sceneLayoutOut, {
         font: opts.font,
         scene: opts.id,
-        data: opts.fullData,
+        data: fullGl3dData,
         bgColor: bgColorCombined,
         calendar: opts.calendar,
         fullLayout: opts.fullLayout

test/image/baselines/gl3d_surface_after_heatmap.png

@@ -0,0 +1,29 @@
+{
+    "data": [
+      {
+        "type": "heatmap",
+        "x": [0, 1, 2],
+        "y": [0, 1, 2],
+        "z": [
+          [0, 1, 0],
+          [1, 0, 1],
+          [0, 1, 0]
+        ]
+      },
+      {
+        "type": "surface",
+        "x": [0, 1, 2],
+        "y": [0, 1, 2],
+        "z": [
+          [0, 1, 0],
+          [1, 0, 1],
+          [0, 1, 0]
+        ]
+      }
+    ],
+    "layout": {
+        "title": "Surface 3d plot on top of 2d heatmap!",
+        "width": 600,
+        "height": 400
+    }
+}