adding test for coerce colorlist, cleanup

Author: cixzhang

src/lib/coerce.js

@@ -152,7 +152,7 @@ exports.valObjectMeta = {
             function isColor(color) {
                 return tinycolor(color).isValid();
             }
-            if(!Array.isArray(v)) propOut.set(dflt);
+            if(!Array.isArray(v) || !v.length) propOut.set(dflt);
             else if(v.every(isColor)) propOut.set(v);
             else propOut.set(dflt);
         }

test/image/mocks/layout-colorway.json

@@ -8,9 +8,7 @@
     {
       "labels": ["a","b","c","c","c","a","d","e","f","f","g","h"],
       "type": "pie",
-      "domain": {"x": [0, 0.4]},
-      "xaxis": "x2",
-      "yaxis": "y2"
+      "domain": {"x": [0, 0.4]}
     }
   ],
   "layout": {
@@ -24,9 +22,6 @@
     ],
     "xaxis": {
       "domain": [0.4, 1]
-    },
-    "yaxis": {
-      "anchor": "y2"
     }
   }
 }

test/jasmine/tests/lib_test.js

@@ -1073,6 +1073,15 @@ describe('Test lib.js:', function() {
             });
         });
 
+        it('should work for valType \'colorlist\' where', function() {
+            var shouldPass = [['red'],['#ffffff'],['rgba(0,0,0,1)'], ['red', 'green', 'blue']],
+                shouldFail = [1, null, undefined, {}, [], 'red', ['red', null]];
+
+            assert(shouldPass, shouldFail, {
+                valType: 'colorlist'
+            });
+        });
+
         it('should work for valType \'colorscale\' where', function() {
             var good = [ [0, 'red'], [1, 'blue'] ],
                 bad = [ [0.1, 'red'], [1, 'blue'] ],