enh: make run() awaitable and bubble exceptions rather than process.exit(1) #429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I like this change, but it's technically a breaking change. Let's merge your other PRs, then we can address this. Sorry for the delays on this all - it's been a busy/rough month |
|
Do we have a system for tagging open PRs for future releases? How would you feel about making a |
benallfree
changed the title
benallfree
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@crutchcorn Can you take a look at this please, I think it might be helpful for the community.
This PR does two things:
run()awaitable. Previously,run()was fire-and-forget, but this doesn't work well when wrapping Plop. I needed a way toawait run().run()was not bubbling exceptions. It was callingprocess.exit, but that is insufficient if the user has setup/teardown that needs to happen afterrun().