Ensure addMany actions strip extensions correctly on dot files

Author: alarner

packages/node-plop/src/actions/addMany.js

@@ -106,7 +106,7 @@ function stripExtensions(shouldStrip, fileName) {
   )
     return fileName;
 
-  return path.parse(maybeFile.name).ext !== ""
+  return path.parse(maybeFile.name).ext !== "" || maybeFile.name.startsWith(".")
     ? path.join(maybeFile.dir, maybeFile.name)
     : fileName;
 }

packages/node-plop/tests/addMany-strip-extensions/addMany-strip-extensions.spec.js

@@ -36,4 +36,18 @@ describe("addMany-strip-extensions", function () {
     expect(fs.existsSync(nonSpecPath)).toBe(true);
     expect(fs.existsSync(specPath)).toBe(true);
   });
+
+  test("Check that dot files generated without hbs extension", () => {
+    const dotPath = path.resolve(
+      testSrcPath,
+      "remove-dotfile-hbs/.gitignore"
+    );
+    const dotPathWithExtension = path.resolve(
+      testSrcPath,
+      "remove-dotfile-hbs/.eslintrc.cjs"
+    );
+
+    expect(fs.existsSync(dotPath)).toBe(true);
+    expect(fs.existsSync(dotPathWithExtension)).toBe(true);
+  });
 });

packages/node-plop/tests/addMany-strip-extensions/plop-templates/remove-dotfile-hbs/.eslintrc.cjs.hbs

@@ -30,6 +30,14 @@ export default function (plop) {
         templateFiles: "plop-templates/remove-all/*",
         abortOnFail: true,
       },
+      {
+        type: "addMany",
+        destination: "src/",
+        stripExtensions: ["hbs"],
+        templateFiles: "plop-templates/remove-dotfile-hbs/*",
+        abortOnFail: true,
+        globOptions: { dot: true },
+      },
     ],
   });
 }