diff --git a/.github/workflows/ci-integration-db-sqlalchemy-v1.yaml b/.github/workflows/ci-integration-db-sqlalchemy-v1.yaml deleted file mode 100644 index 4e8fbc554..000000000 --- a/.github/workflows/ci-integration-db-sqlalchemy-v1.yaml +++ /dev/null @@ -1,46 +0,0 @@ -# CI - DB Integration - SqlAlchemy v1 is designed to run integration testing against SQLAlchemy v1. -# Target database: Clickhouse -# Sqlalchemy version: 1.4 (required by clickhouse-sqlalchemy) - -name: CI - DB Integration - SQLAlchemy V1 - -on: - workflow_call: - -jobs: - database-sqlalchemy-v1-integration-test: - strategy: - matrix: - python-version: ['3.11'] - os: [ubuntu-latest] - runs-on: ${{ matrix.os }} - - env: - PLOOMBER_VERSION_CHECK_DISABLED: true - PYTHON_VERSION: ${{ matrix.python-version }} - - steps: - - name: Checkout - uses: actions/checkout@v2 - - - name: Set up Python ${{ matrix.python-version }} - uses: actions/setup-python@v2 - with: - python-version: ${{ matrix.python-version }} - - - name: Install dependencies - run: | - python -m pip install --upgrade pip - python -m pip install --upgrade nox - nox --session test_integration_sqlachemy_v1 --install-only - - - name: Integration Test - run: | - nox --session test_integration_sqlachemy_v1 --no-install --reuse-existing-virtualenvs - - - name: Upload failed images artifacts - uses: actions/upload-artifact@v3 - if: failure() - with: - name: failed-image-artifacts-sqlalchemy-v1 ${{ matrix.os }} ${{ matrix.python-version }} - path: result_images/ \ No newline at end of file diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index c9fe17b0d..a79bb052f 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -71,12 +71,6 @@ jobs: exit 0 fi - - integration-test-sqlalchemy-v1: - needs: [preliminary] - if: needs.preliminary.outputs.check_doc_modified == 'failure' - uses: ./.github/workflows/ci-integration-db-sqlalchemy-v1.yaml - integration-test-non-live: needs: [preliminary] if: needs.preliminary.outputs.check_doc_modified == 'failure' @@ -196,7 +190,7 @@ jobs: release: - needs: [test, test-sqlalchemy-v1, check, integration-test-non-live, integration-test-sqlalchemy-v1] + needs: [test, test-sqlalchemy-v1, check, integration-test-non-live] if: startsWith(github.ref, 'refs/tags') && github.event_name != 'pull_request' runs-on: ubuntu-latest diff --git a/noxfile.py b/noxfile.py index 58362ccf1..c425e1b8f 100644 --- a/noxfile.py +++ b/noxfile.py @@ -150,34 +150,6 @@ def test_integration_cloud(session): ) -@nox.session( - venv_backend=VENV_BACKEND, - python=environ.get("PYTHON_VERSION", "3.11"), -) -def test_integration_sqlachemy_v1(session): - """ - Run integration tests on SQLAlchemy v1 - (NOTE: the clickhouse-sqlalchemy driver only works with - SQLAlchemy 1.x) - """ - - # tests - _install(session, integration=True) - session.install( - "snowflake-sqlalchemy", - "redshift-connector", - "sqlalchemy-redshift", - "clickhouse-sqlalchemy", - ) - session.run( - "pytest", - "src/tests/integration", - "-k", - "clickhouse", - "-v", - ) - - @nox.session( venv_backend=VENV_BACKEND, python=environ.get("PYTHON_VERSION", "3.11"),