Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix workflow-edits workflow #64

Open
edublancas opened this issue May 29, 2023 · 0 comments
Open

fix workflow-edits workflow #64

edublancas opened this issue May 29, 2023 · 0 comments
Labels
good first issue Good for newcomers

Comments

@edublancas
Copy link
Contributor

edublancas commented May 29, 2023 •
edited
Loading

the workflow-edits fails the CI if a given PR modifies the .github/workflows directory. However, it has an issue.

It'll also fail if the change originated from the master/main branch - which shouldn't. The problem is in the git diff command, we can fix by using the ... operator (as explained here)

we also need to update jupysql's copy: https://github.com/ploomber/jupysql/blob/master/.github/workflows/workflow-edits.yml
@edublancas edublancas added the good first issue Good for newcomers label May 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@edublancas