Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve link integrity popup volto17 #6517

Merged
merged 6 commits into from
Dec 11, 2024

Conversation

giuliaghisini
Copy link
Contributor

@giuliaghisini giuliaghisini commented Dec 6, 2024

backport of #6516

fixed and improved link integrity popup when deleting item/items from folder contents.
Moved all code in a separate component 'ContentsDeleteModal'.

Added loader when loading references. If the call to @linkintegrity took a long time to load, it wasn't clear to the user that it was checking for broken references:

loading

If only one item is selected to delete, it will display all the possibile broken references in a table, instead in a list. In the last column could be more than one reference:
1-selected-item

If more than one item is selected to delete, it will not display the possibile broken references, but only the number, because it will be a very long list (It worked like that before too):
more-than-one-selected


📚 Documentation preview 📚: https://volto--6517.org.readthedocs.build/

@giuliaghisini giuliaghisini changed the base branch from main to 17.x.x December 6, 2024 14:11
Copy link

netlify bot commented Dec 6, 2024

Deploy Preview for plone-components failed. Why did it fail? →

Name Link
🔨 Latest commit 494fe24
🔍 Latest deploy log https://app.netlify.com/sites/plone-components/deploys/675305f727cd6700080c0c49

@sneridagh
Copy link
Member

@plone/volto-team approved, since it does not break the policy, since it applies to the CMSUI.

@sneridagh sneridagh merged commit e8eb76b into 17.x.x Dec 11, 2024
47 checks passed
@sneridagh sneridagh deleted the improve_link_integrity_popup_volto17 branch December 11, 2024 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants