-
-
Notifications
You must be signed in to change notification settings - Fork 688
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add references for contributing to latest and earlier versions of Volto #6184
Conversation
✅ Deploy Preview for plone-components canceled.
|
I'm not sure why CI checks fail, as this PR is only about docs. |
This chapter describes how to develop the latest version of Volto core and its libraries, packages, and apps as open source software contributions. | ||
|
||
```{seealso} | ||
For previous versions of Volto core, you should follow the guide {doc}`plone:contributing/core/index`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@stevepiercy This is wrong because the plone contribute to core describes only how to contribute to Plone core using buildout
https://6.docs.plone.org/contributing/core/index.html
In previous versions of Volto we didn't teach that users should use the buildout core to develop either.
We had the same setup to start the backend using the make command although with previous naming.
For me it makes more sense for previous versions of Volto if docker installation isn't preferred to reffer to the api folder which gives info on how to create the backend this way https://github.com/plone/volto/tree/17.x.x/api
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alternatively, we don't write anything as the flow is always contributing to the main branch followed by backports if it's not a breaking change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right. Plus docs have changed significantly. I updated the text in 076d250. One more review please!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
The failing check is a flaky test, totally unrelated to docs. Merging. Thanks for your help! |
Closes #6157
📚 Documentation preview 📚: https://volto--6184.org.readthedocs.build/