Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added entry on redirect after logout #6086

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

pigeonflight
Copy link
Member

@pigeonflight pigeonflight commented Jun 9, 2024

This pull request documents the process of customizing the logout functionality in Volto to automatically redirect users to the login page after they log out. By default, Volto does not redirect users to the login page after logging out, which can be confusing for users who expect to be taken back to the login page.


📚 Documentation preview 📚: https://volto--6086.org.readthedocs.build/

@mister-roboto
Copy link

David Bain your emails are not known to GitHub and thus it is impossible to know if you have signed the Plone Contributor Agreement, which is required to merge this pull request.

Learn about the Plone Contributor Agreement: https://plone.org/foundation/contributors-agreement How to add more emails to your GitHub account: https://docs.github.com/en/account-and-profile/setting-up-and-managing-your-personal-account-on-github/managing-email-preferences/adding-an-email-address-to-your-github-account

Copy link

netlify bot commented Jun 9, 2024

Deploy Preview for plone-components canceled.

Name Link
🔨 Latest commit 4464faa
🔍 Latest deploy log https://app.netlify.com/sites/plone-components/deploys/66a72ba66480fe00084eccb8

@mister-roboto
Copy link

David Bain your emails are not known to GitHub and thus it is impossible to know if you have signed the Plone Contributor Agreement, which is required to merge this pull request.

Learn about the Plone Contributor Agreement: https://plone.org/foundation/contributors-agreement How to add more emails to your GitHub account: https://docs.github.com/en/account-and-profile/setting-up-and-managing-your-personal-account-on-github/managing-email-preferences/adding-an-email-address-to-your-github-account

@stevepiercy
Copy link
Collaborator

@pigeonflight I'm pretty sure you signed a Plone Contributor Agreement at some point. However, you need to add the email address that you used to sign your PCA to your GitHub account, and then we can review your PR. Please let us know. Thank you!

@pigeonflight
Copy link
Member Author

@pigeonflight I'm pretty sure you signed a Plone Contributor Agreement at some point. However, you need to add the email address that you used to sign your PCA to your GitHub account, and then we can review your PR. Please let us know. Thank you!

@stevepiercy I'm not sure which email I used but I've updated my github account today with the email address that I believe I used.
Should I cancel this pull request and try again?

@stevepiercy
Copy link
Collaborator

I'll close and reopen this PR, and that usually jiggers the switch.

@stevepiercy stevepiercy reopened this Jun 10, 2024
@mister-roboto
Copy link

David Bain your emails are not known to GitHub and thus it is impossible to know if you have signed the Plone Contributor Agreement, which is required to merge this pull request.

Learn about the Plone Contributor Agreement: https://plone.org/foundation/contributors-agreement How to add more emails to your GitHub account: https://docs.github.com/en/account-and-profile/setting-up-and-managing-your-personal-account-on-github/managing-email-preferences/adding-an-email-address-to-your-github-account

@stevepiercy
Copy link
Collaborator

@pigeonflight the email you added still does not match whatever was entered on your agreement. Would you please send mail to [email protected] and ask which email they have on record and should be used? Alternatively you could just submit a new agreement as described in https://plone.org/foundation/contributors-agreement.

@stevepiercy
Copy link
Collaborator

@pigeonflight also Volto requires a change log entry, per https://6.docs.plone.org/contributing/index.html#change-log-entry

@pigeonflight
Copy link
Member Author

@pigeonflight the email you added still does not match whatever was entered on your agreement. Would you please send mail to [email protected] and ask which email they have on record and should be used? Alternatively you could just submit a new agreement as described in https://plone.org/foundation/contributors-agreement.

I went ahead and signed a new agreement and I've added that email address to my github. Once that has been added, we can try again.

@mister-roboto
Copy link

David Bain your emails are not known to GitHub and thus it is impossible to know if you have signed the Plone Contributor Agreement, which is required to merge this pull request.

Learn about the Plone Contributor Agreement: https://plone.org/foundation/contributors-agreement How to add more emails to your GitHub account: https://docs.github.com/en/account-and-profile/setting-up-and-managing-your-personal-account-on-github/managing-email-preferences/adding-an-email-address-to-your-github-account

@mister-roboto
Copy link

David Bain your emails are not known to GitHub and thus it is impossible to know if you have signed the Plone Contributor Agreement, which is required to merge this pull request.

Learn about the Plone Contributor Agreement: https://plone.org/foundation/contributors-agreement How to add more emails to your GitHub account: https://docs.github.com/en/account-and-profile/setting-up-and-managing-your-personal-account-on-github/managing-email-preferences/adding-an-email-address-to-your-github-account

@stevepiercy
Copy link
Collaborator

Going to try closing and reopening, now that @pigeonflight is a member of Plone Developers.

@stevepiercy stevepiercy reopened this Jun 20, 2024
@mister-roboto
Copy link

David Bain your emails are not known to GitHub and thus it is impossible to know if you have signed the Plone Contributor Agreement, which is required to merge this pull request.

Learn about the Plone Contributor Agreement: https://plone.org/foundation/contributors-agreement How to add more emails to your GitHub account: https://docs.github.com/en/account-and-profile/setting-up-and-managing-your-personal-account-on-github/managing-email-preferences/adding-an-email-address-to-your-github-account

@mister-roboto
Copy link

David Bain your emails are not known to GitHub and thus it is impossible to know if you have signed the Plone Contributor Agreement, which is required to merge this pull request.

Learn about the Plone Contributor Agreement: https://plone.org/foundation/contributors-agreement How to add more emails to your GitHub account: https://docs.github.com/en/account-and-profile/setting-up-and-managing-your-personal-account-on-github/managing-email-preferences/adding-an-email-address-to-your-github-account

@stevepiercy
Copy link
Collaborator

@pigeonflight this PR needs a change log entry, per https://6.docs.plone.org/contributing/index.html#change-log-entry

docs/source/development/redirect-after-logout.md Outdated Show resolved Hide resolved
docs/source/development/redirect-after-logout.md Outdated Show resolved Hide resolved
docs/source/development/redirect-after-logout.md Outdated Show resolved Hide resolved
docs/source/development/redirect-after-logout.md Outdated Show resolved Hide resolved
docs/source/development/redirect-after-logout.md Outdated Show resolved Hide resolved
docs/source/development/redirect-after-logout.md Outdated Show resolved Hide resolved
docs/source/development/redirect-after-logout.md Outdated Show resolved Hide resolved
docs/source/development/redirect-after-logout.md Outdated Show resolved Hide resolved
docs/source/development/redirect-after-logout.md Outdated Show resolved Hide resolved
@mister-roboto
Copy link

David Bain your emails are not known to GitHub and thus it is impossible to know if you have signed the Plone Contributor Agreement, which is required to merge this pull request.

Learn about the Plone Contributor Agreement: https://plone.org/foundation/contributors-agreement How to add more emails to your GitHub account: https://docs.github.com/en/account-and-profile/setting-up-and-managing-your-personal-account-on-github/managing-email-preferences/adding-an-email-address-to-your-github-account

@mister-roboto
Copy link

David Bain your emails are not known to GitHub and thus it is impossible to know if you have signed the Plone Contributor Agreement, which is required to merge this pull request.

Learn about the Plone Contributor Agreement: https://plone.org/foundation/contributors-agreement How to add more emails to your GitHub account: https://docs.github.com/en/account-and-profile/setting-up-and-managing-your-personal-account-on-github/managing-email-preferences/adding-an-email-address-to-your-github-account

Copy link
Collaborator

@stevepiercy stevepiercy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The docs look good to me. Could I get a second pair of eyes on the code sample? @plone/volto-team

@stevepiercy
Copy link
Collaborator

@pigeonflight suggest emailing [email protected] to find out which email they have on record for you and to resolve the matter. Once you get it straightened out, would you please add a comment to this PR? Thank you!

@mister-roboto
Copy link

David Bain your emails are not known to GitHub and thus it is impossible to know if you have signed the Plone Contributor Agreement, which is required to merge this pull request.

Learn about the Plone Contributor Agreement: https://plone.org/foundation/contributors-agreement How to add more emails to your GitHub account: https://docs.github.com/en/account-and-profile/setting-up-and-managing-your-personal-account-on-github/managing-email-preferences/adding-an-email-address-to-your-github-account

@ichim-david
Copy link
Member

@pigeonflight it seems your account is still flagged by mister-roboto. Unless you get this sorted we can't merge your pull request.

To redirect users to the login page after they log out in Volto, you need to customize the `PersonalTools` component.
Follow these steps.

1. **Shadow the component**: Create a new file at `customizations/components/manage/Toolbar/PersonalTools.jsx`, then copy the contents of the original file from {file}`volto/packages/volto/src/components/manage/Toolbar/PersonalTools.jsx` into the new file.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the best place to do so is in the View, rather than customizing the component as a whole. For example we do redirect to login when unauthorized https://github.com/eea/volto-eea-website-theme/blob/ff514ef4cd7833edcf3956f300092554a0d8ac2e/src/customizations/volto/components/theme/Unauthorized/Unauthorized.jsx#L28

@stevepiercy
Copy link
Collaborator

@pigeonflight we figured out the problem with the email mismatch. The email on your commit message must match one of the emails in your GitHub account. You have three different emails used in your commits, and we think that the first one wins. From https://6.docs.plone.org/contributing/core/continuous-integration.html#mr-roboto:

You could also squash the commits using the email configured for your GitHub account, then push to this branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: New
Development

Successfully merging this pull request may close these issues.

6 participants