Extensible validation support in Volto forms (#6181)

Co-authored-by: David Ichim <[email protected]> Co-authored-by: David Glick <[email protected]> Co-authored-by: Steve Piercy <[email protected]> Co-authored-by: Tisha Soumya <[email protected]>
plone · Jul 30, 2024 · 9f8c1e9 · 9f8c1e9
1 parent 88e1894
commit 9f8c1e9
Show file tree

Hide file tree

Showing 65 changed files with 3,376 additions and 292 deletions.
diff --git a/.github/actions/node_env_setup/action.yml b/.github/actions/node_env_setup/action.yml
@@ -36,7 +36,7 @@ runs:
 
     - name: Install Volto dependencies
       shell: bash
-      run: pnpm i
+      run: make install
 
     - name: Install Cypress if not in cache
       if: steps.cache-cypress-binary.outputs.cache-hit != 'true'

diff --git a/.github/workflows/acceptance.yml b/.github/workflows/acceptance.yml
@@ -497,45 +497,11 @@ jobs:
     steps:
       - uses: actions/checkout@v4
 
-      # node setup
-      - name: Use Node.js ${{ matrix.node-version }}
-        uses: actions/setup-node@v4
+      - name: Set up Node.js environment
+        uses: ./.github/actions/node_env_setup
         with:
           node-version: ${{ matrix.node-version }}
 
-      - name: Enable corepack
-        run: corepack enable
-
-      - name: Get pnpm store directory
-        shell: bash
-        run: |
-          echo "STORE_PATH=$(pnpm store path --silent)" >> $GITHUB_ENV
-
-      - uses: actions/cache@v4
-        name: Setup pnpm cache
-        with:
-          path: ${{ env.STORE_PATH }}
-          key: ${{ runner.os }}-pnpm-store-${{ hashFiles('**/pnpm-lock.yaml') }}
-          restore-keys: |
-            ${{ runner.os }}-pnpm-store-
-
-      - name: Cache Cypress Binary
-        id: cache-cypress-binary
-        uses: actions/cache@v4
-        with:
-          path: ~/.cache/Cypress
-          key: binary-${{ matrix.node-version }}-${{ hashFiles('pnpm-lock.yaml') }}
-
-      - run: pnpm i
-
-      - name: Build dependencies
-        run: pnpm build:deps
-
-      - name: Install Cypress if not in cache
-        if: steps.cache-cypress-binary.outputs.cache-hit != 'true'
-        working-directory: packages/volto
-        run: make cypress-install
-
       # Generator own tests
       - name: Generator tests
         run: pnpm test

diff --git a/.github/workflows/unit.yml b/.github/workflows/unit.yml
@@ -16,30 +16,11 @@ jobs:
     steps:
       - uses: actions/checkout@v4
 
-      # node setup
-      - name: Use Node.js ${{ matrix.node-version }}
-        uses: actions/setup-node@v4
+      - name: Set up Node.js environment
+        uses: ./.github/actions/node_env_setup
         with:
           node-version: ${{ matrix.node-version }}
 
-      - name: Enable corepack
-        run: corepack enable
-
-      - name: Get pnpm store directory
-        shell: bash
-        run: |
-          echo "STORE_PATH=$(pnpm store path --silent)" >> $GITHUB_ENV
-
-      - uses: actions/cache@v4
-        name: Setup pnpm cache
-        with:
-          path: ${{ env.STORE_PATH }}
-          key: ${{ runner.os }}-pnpm-store-${{ hashFiles('**/pnpm-lock.yaml') }}
-          restore-keys: |
-            ${{ runner.os }}-pnpm-store-
-
-      - run: pnpm i
-
       # Locales in place are needed for the tests to pass
       - run: pnpm --filter @plone/volto i18n
 

diff --git a/Makefile b/Makefile
@@ -69,10 +69,11 @@ clean: ## Clean development environment
 	find ./packages -name node_modules -exec rm -rf {} \;
 
 .PHONY: install
-install: build-deps ## Set up development environment
+install: ## Set up development environment
 	# Setup ESlint for VSCode
-	node packages/scripts/vscodesettings.js
 	pnpm i
+	node packages/scripts/vscodesettings.js
+	make build-deps
 
 ##### Documentation
 
@@ -137,10 +138,10 @@ docs-test: docs-clean docs-linkcheckbroken docs-vale  ## Clean docs build, then
 cypress-install: ## Install Cypress for acceptance tests
 	$(NODEBIN)/cypress install
 
-packages/registry/dist: packages/registry/src
+packages/registry/dist: $(shell find packages/registry/src -type f)
 	pnpm build:registry
 
-packages/components/dist: packages/components/src
+packages/components/dist: $(shell find packages/components/src -type f)
 	pnpm build:components
 
 .PHONY: build-deps

diff --git a/docs/source/configuration/index.md b/docs/source/configuration/index.md
@@ -27,4 +27,5 @@ environmentvariables
 expanders
 locking
 slots
+validation
 ```
-Original file line number
+Diff line change
@@ Expand Up / @@ -27,4 +27,5 @@ environmentvariables @@
     expanders
     locking
     slots
+    validation
     ```