Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change tile width dynamically to allow longer strings #54

Open
BayMinimum opened this issue Oct 19, 2018 · 5 comments
Open

Change tile width dynamically to allow longer strings #54

BayMinimum opened this issue Oct 19, 2018 · 5 comments
Labels
bug Something isn't working hard-blocked Another issue is preventing this moving forward. It cannot continue without clearing the issue.

Comments

@BayMinimum
Copy link

image
Not really a priority, but this is going to happen as number grows beyond 8192 😢, since current implementation uses std::setw(4) when prining each tile.
@plibither8 plibither8 mentioned this issue Oct 19, 2018
Open
@plibither8
Copy link
Owner

I think this is a small bug and should be a quick fix if we work towards it!

@plibither8 plibither8 changed the title Change max tile width dynamically? Change tile width dynamically to allow longer strings Oct 19, 2018
@plibither8 plibither8 added bug Something isn't working good first issue Good for newcomers hacktoberfest labels Oct 19, 2018
@cawvyoct
Copy link
Collaborator

As spotted, the game's UI is too binded with the game's logic. Currently working to separate the two.
(PR:#36 was the start of this to see if it would be accepted into the codebase).

@plibither8
Copy link
Owner

You raised a good issue. Had I started development of the game with decoupled UI-logic in mind, it would have reduced the need for large code refactoring. #36 was a great start! I have added you (@cawvyoct) as a collaborator to this repository 😄

@Scronkfinkle Scronkfinkle mentioned this issue Oct 23, 2018
Closed
@Scronkfinkle
Copy link

Although the UI and logic are locked together, we can reference the largestTile variable and expand the table accordingly, since it is calculated before the UI updates. Implemented in #56

@tcoyvwac tcoyvwac mentioned this issue Oct 13, 2019
Closed
@tcoyvwac tcoyvwac added hard-blocked Another issue is preventing this moving forward. It cannot continue without clearing the issue. and removed good first issue Good for newcomers labels Oct 13, 2019
@tcoyvwac
Copy link
Collaborator

This Issue is currently dependent on Issue #51 (themed tiles). It could also be dependent on Issue #89 (multi-language support). Further thought is requires so this Issue is currently blocked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working hard-blocked Another issue is preventing this moving forward. It cannot continue without clearing the issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change tile width dynamically to allow longer strings
5 participants
@Scronkfinkle @BayMinimum @plibither8 @cawvyoct @tcoyvwac