Skip to content

Commit ea0c04d

Browse files
authored
Update Go to 1.23.2 to make puku aware of package iter (#135)
Also, remove checked-in generated file and update .plzconfig to make it generate imports
1 parent 2807326 commit ea0c04d

File tree

8 files changed

+19
-275
lines changed

8 files changed

+19
-275
lines changed

Diff for: .github/workflows/golangci-lint.yml

+3
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,9 @@ jobs:
1515
- uses: actions/setup-go@v2
1616
with:
1717
go-version: "^1.23"
18+
- name: Build go_root_packages
19+
# This makes sure the knownimports/go_root_packages file exists as a real file for golangci-lint
20+
run: ./pleasew build //knownimports:go_root_packages && mv $(readlink knownimports/go_root_packages) knownimports/go_root_packages
1821
- name: golangci-lint
1922
uses: golangci/golangci-lint-action@v2
2023
with:

Diff for: .plzconfig

+6-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,11 @@
11
[parse]
22
preloadsubincludes = ///go//build_defs:go
33

4+
[build]
5+
LinkGeneratedSources = true
6+
DownloadLinkable = true
7+
UpdateGitignore = true
8+
49
[Plugin "go"]
510
Target = //plugins:go
611
ImportPath = github.com/please-build/puku
@@ -19,4 +24,4 @@ Desc = Runs golangci-lint as done by our CI
1924
cmd = run //third_party/binary:golangci-lint -- run
2025

2126
[BuildConfig]
22-
go-version = 1.22.3
27+
go-version = 1.23.2

Diff for: ChangeLog

+4
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
Version 1.13.0
2+
--------------
3+
* Build with Go 1.23.2 to pull in new packages
4+
15
Version 1.12.1
26
--------------
37
* Rename `VERSION` to `PUKU_VERSION` to allow running

Diff for: PUKU_VERSION

+1-1
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
1.12.1
1+
1.13.0

Diff for: go.mod

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
module github.com/please-build/puku
22

3-
go 1.19
3+
go 1.23
44

55
require (
66
github.com/fsnotify/fsnotify v1.7.0

Diff for: knownimports/.gitignore

+3
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
2+
# Entries below this point are managed by Please (DO NOT EDIT)
3+
go_root_packages

Diff for: knownimports/BUILD

+1
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ genrule(
55
srcs = ["//third_party/go:toolchain"],
66
outs = ["go_root_packages"],
77
cmd = f'find {root} -name "*.a" | sed -e s=^{root}/== | sed -e s="\.a\$"== > $OUT',
8+
labels = ["codegen"],
89
)
910

1011
go_library(

Diff for: knownimports/go_root_packages

-272
This file was deleted.

0 commit comments

Comments
 (0)