Skip to content

Commit 95b21e4

Browse files
Use arcat instead of jarcat (#22)
Invoke the jarcat tool with its new name, arcat. Co-authored-by: Chris Novakovic <[email protected]>
1 parent 4a81789 commit 95b21e4

File tree

2 files changed

+9
-9
lines changed

2 files changed

+9
-9
lines changed

Diff for: build_defs/cc.build_defs

+6-6
Original file line numberDiff line numberDiff line change
@@ -164,13 +164,13 @@ def cc_library(name:str, srcs:list=[], hdrs:list=[], private_hdrs:list=[], deps:
164164
tag = 'a',
165165
srcs = {'srcs': a_rules},
166166
outs = [out],
167-
cmd = '"$TOOLS_JARCAT" ar --combine && "$TOOLS_AR" s "$OUT"',
167+
cmd = '"$TOOLS_ARCAT" ar --combine && "$TOOLS_AR" s "$OUT"',
168168
building_description = 'Archiving...',
169169
test_only = test_only,
170170
labels = labels,
171171
output_is_complete = True,
172172
tools = {
173-
'jarcat': [CONFIG.JARCAT_TOOL],
173+
'arcat': [CONFIG.ARCAT_TOOL],
174174
'ar': [CONFIG.CC.AR_TOOL],
175175
},
176176
)
@@ -355,7 +355,7 @@ def cc_static_library(name:str, srcs:list=[], hdrs:list=[], compiler_flags:list&
355355
name = name,
356356
deps = deps,
357357
outs = [out],
358-
cmd = '"$TOOLS_JARCAT" ar --find && "$TOOLS_AR" s "$OUT"',
358+
cmd = '"$TOOLS_ARCAT" ar --find && "$TOOLS_AR" s "$OUT"',
359359
needs_transitive_deps = True,
360360
output_is_complete = True,
361361
visibility = visibility,
@@ -364,7 +364,7 @@ def cc_static_library(name:str, srcs:list=[], hdrs:list=[], compiler_flags:list&
364364
provides = provides,
365365
requires = ['cc'],
366366
tools = {
367-
'jarcat': [CONFIG.JARCAT_TOOL],
367+
'arcat': [CONFIG.ARCAT_TOOL],
368368
'ar': [CONFIG.CC.AR_TOOL],
369369
},
370370
labels = labels,
@@ -724,7 +724,7 @@ def _library_cmds(c, compiler_flags, pkg_config_libs, pkg_config_cflags, extra_f
724724
opt_flags = _build_flags(compiler_flags, pkg_config_libs, pkg_config_cflags, c=c)
725725
cmd_template = '$TOOLS_CC -c -I . ${SRCS_SRCS} %s %s'
726726
if archive:
727-
cmd_template += ' && "$TOOLS_JARCAT" ar -r && "$TOOLS_AR" s "$OUT"'
727+
cmd_template += ' && "$TOOLS_ARCAT" ar -r && "$TOOLS_AR" s "$OUT"'
728728
cmds = {
729729
'dbg': cmd_template % (dbg_flags, extra_flags),
730730
'opt': cmd_template % (opt_flags, extra_flags),
@@ -733,7 +733,7 @@ def _library_cmds(c, compiler_flags, pkg_config_libs, pkg_config_cflags, extra_f
733733
cmds['cover'] = cmd_template % (dbg_flags + _COVERAGE_FLAGS, extra_flags)
734734
return cmds, {
735735
'cc': [CONFIG.CC.CC_TOOL if c else CONFIG.CC.CPP_TOOL],
736-
'jarcat': [CONFIG.JARCAT_TOOL if archive else None],
736+
'arcat': [CONFIG.ARCAT_TOOL if archive else None],
737737
'ar': [CONFIG.CC.AR_TOOL if archive else None],
738738
}
739739

Diff for: build_defs/cc_embed_binary.build_defs

+3-3
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ def cc_embed_binary(name:str, src:str, deps:list=[], visibility:list=None,
5050
test_only = test_only,
5151
)
5252

53-
tools = {'jarcat': [CONFIG.JARCAT_TOOL], 'ar': [CONFIG.AR_TOOL]}
53+
tools = {'arcat': [CONFIG.ARCAT_TOOL], 'ar': [CONFIG.AR_TOOL]}
5454
if darwin:
5555
# OSX's ld doesn't support '--format binary', and this is the least fiddly
5656
# alternative. Requiring an additional tool is a bit suboptimal but probably
@@ -59,12 +59,12 @@ def cc_embed_binary(name:str, src:str, deps:list=[], visibility:list=None,
5959
'export ENCODED_FILENAME=${SRCS//[\\/\\.]/_}',
6060
f'echo "{_CC_DARWIN_ASM_CONTENTS}" > embedded.asm',
6161
'$TOOLS_ASM -fmacho64 embedded.asm -o ${OUTS/.a/.o}',
62-
'$TOOLS_JARCAT ar --srcs ${OUTS/.a/.o}',
62+
'$TOOLS_ARCAT ar --srcs ${OUTS/.a/.o}',
6363
'$TOOLS_AR s $OUTS',
6464
])
6565
tools['asm'] = [CONFIG.CC.ASM_TOOL]
6666
else:
67-
cmd = '$TOOLS_LD -r --format binary %s -o ${OUTS/.a/.o} $SRC && $TOOLS_JARCAT ar --srcs ${OUTS/.a/.o} && $TOOLS_AR s $OUTS' % CONFIG.DEFAULT_LDFLAGS
67+
cmd = '$TOOLS_LD -r --format binary %s -o ${OUTS/.a/.o} $SRC && $TOOLS_ARCAT ar --srcs ${OUTS/.a/.o} && $TOOLS_AR s $OUTS' % CONFIG.DEFAULT_LDFLAGS
6868
tools['ld'] = [CONFIG.LD_TOOL]
6969

7070
lib_rule = build_rule(

0 commit comments

Comments
 (0)