Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use isInBlock instead of isFinalized #4

Closed
Tracked by #1
jam10o-new opened this issue Feb 23, 2020 · 1 comment
Closed
Tracked by #1

use isInBlock instead of isFinalized #4

jam10o-new opened this issue Feb 23, 2020 · 1 comment

Comments

@jam10o-new
Copy link

what was previously named "isFinalized" is now named "isInBlock" - (isFinalized now actually triggers on finality, not block inclusion), we probably want to respond to events when they are isInBlock, not isFinalized.

super-long-term, a more robust mechanism would wait for finality and retry actions if finality is not achieved before dropping the extrinsic callback.

@serapath serapath mentioned this issue Feb 26, 2020
12 tasks
@ninabreznik
Copy link
Member

Ok, so I am pulling new version of datdot-substrate, building it and then changing in datdot-service isFinalized to isInBlock and will first try if all still works. If yes, I continue with adding js part for the attestation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants