Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Constructor parameter 'leaderboardId' is not used. #3120

Open
epsmarkh opened this issue Mar 3, 2022 · 1 comment · May be fixed by #3121
Open

Constructor parameter 'leaderboardId' is not used. #3120

epsmarkh opened this issue Mar 3, 2022 · 1 comment · May be fixed by #3121
Labels

Comments

@epsmarkh
Copy link

epsmarkh commented Mar 3, 2022

Describe the bug
In the PlayGamesScore constructor, the parameter 'leaderboardId' is not used and the function is actually using the class variable leaderboardID instead.

To Reproduce
Steps to reproduce the behavior:

  1. View the code in PlayGamesScore.cs
    internal PlayGamesScore(DateTime date, string leaderboardId,
    ulong rank, string playerId, ulong value, string metadata)
    {
    this.mDate = date;
    mLbId = leaderboardID;
    this.mRank = rank;
    this.mPlayerId = playerId;
    this.mValue = (long) value;
    this.mMetadata = metadata;
    }

Note the different case causing the erroneous assignment.

Expected behavior
Parameters passed to the function are used correctly

Observed behavior
Leaderboard id is ignored and the value already in the class is used

Bug Report
NA

Screenshots
NA

Versions

  • Unity version: All
  • Google Play Games Plugin for Unity version: 0.10.14

Additional context
NA

@epsmarkh epsmarkh added the bug label Mar 3, 2022
@mukhinid
Copy link
Contributor

mukhinid commented Mar 4, 2022

Hi, looks like a bug due to a typo. Why don't you open a PR for fix?

@epsmarkh epsmarkh linked a pull request Mar 4, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants