-
-
Notifications
You must be signed in to change notification settings - Fork 544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Format each sample project #118
Comments
I think running the most stable samples in a single travis job could be benefinicial. If memory serves, here's the usual suspect with more recent flakiness or failures:
At least. |
I like the idea of running scalafmt / javafmt for all examples. We currently have that commented out: play-samples/.github/workflows/build-test.yml Lines 15 to 25 in f2a8896
We could place a global scalafmt config in the root folder and have format script that copies that scalamt config into each project and then goes through the projects and runs validateCode. Very similiar to the test script (even combine those two). |
We could add something like https://github.com/akka/akka-guide/blob/54a81ce729ef07e1f9b97f0f15a4ff7d60e4d0ed/scripts/format-all.sh and even remove the separate Travis jobs.
WDYT?
Code, click to exapnd
Originally posted by @ennru in #116 (comment)
The text was updated successfully, but these errors were encountered: