Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support ESLint flat config #443

Merged

Conversation

bmish
Copy link
Collaborator

@bmish bmish commented Dec 10, 2023

Added a new plugin export for using the flat config:

// eslint.config.js
const eslintPluginQunitRecommended = require("eslint-plugin-qunit/configs/recommended");

module.exports = [
    eslintPluginQunitRecommended,
];

Using legacy config is unchanged:

// .eslintrc.js
module.exports = {
  extends: ['plugin:qunit/recommended']
};

Prior art:

Follow-up to:

@bmish bmish force-pushed the support-eslint-flat-config branch 2 times, most recently from 5b7505a to b489bf0 Compare December 10, 2023 23:41
@coveralls
Copy link

coveralls commented Dec 10, 2023

Coverage Status

coverage: 100.0%. remained the same
when pulling 51cd143 on bmish:support-eslint-flat-config
into bc854b0 on platinumazure:master.

@bmish bmish changed the title feat: support eslint flat config feat: support ESLint flat config Dec 10, 2023
@bmish bmish mentioned this pull request Dec 10, 2023
@bmish bmish marked this pull request as ready for review December 10, 2023 23:49
Copy link
Owner

@platinumazure platinumazure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, looks good. Sorry for the delay in reviewing.

I'm basically ready to merge this in, but I'd feel better if we could solve the Coveralls CI problem first (see #461) so that hopefully we don't get a Coveralls error on post-merge CI.

@platinumazure platinumazure merged commit 87890a3 into platinumazure:master Feb 10, 2024
10 checks passed
bmish added a commit to bmish/eslint-plugin-qunit that referenced this pull request Feb 10, 2024
* master:
  feat: support eslint flat config (platinumazure#443)
  upgrade: Bump @typescript-eslint/parser from 6.7.5 to 6.21.0 (platinumazure#465)
  upgrade: Bump typescript from 5.2.2 to 5.3.3 (platinumazure#439)
  upgrade: Bump eslint-plugin-unicorn from 49.0.0 to 51.0.1 (platinumazure#464)
  upgrade: Bump eslint-plugin-eslint-plugin from 5.1.1 to 5.3.0 (platinumazure#463)
  upgrade: Bump globals from 13.23.0 to 14.0.0 (platinumazure#462)
  upgrade: Bump eslint from 8.55.0 to 8.56.0 (platinumazure#450)
  upgrade: Bump @eslint/js from 8.55.0 to 8.56.0 (platinumazure#449)
  upgrade: Bump markdownlint-cli from 0.37.0 to 0.39.0 (platinumazure#459)
  upgrade: Bump github/codeql-action from 2 to 3 (platinumazure#447)
  upgrade: Bump eslint-doc-generator from 1.5.2 to 1.6.2 (platinumazure#455)
  upgrade: Bump release-it from 16.2.1 to 16.3.0 (platinumazure#437)
  ci: Use parallel coveralls config (platinumazure#461)
@Turbo87
Copy link
Contributor

Turbo87 commented Feb 11, 2024

this update appears to fail for the crates.io project with:

ESLint: 8.56.0

Error: ESLint configuration in .eslintrc.js » plugin:qunit/recommended is invalid:
	- Unexpected top-level property "description".

see rust-lang/crates.io#8104

@bmish
Copy link
Collaborator Author

bmish commented Feb 11, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants