refactor: rename some properties

Author: Sobyt483

projects/wc/src/app/components/organization-management/organization-management.component.html

@@ -9,10 +9,10 @@
     }}</ui5-label
     ><br />
     <div class="organization-management-input">
-      @let organizationToSwitchObj = organizationToSwitch();
+      @let newOrganization = organizationToSwitch();
       <ui5-select
         id="select-switch"
-        [value]="organizationToSwitchObj?.name"
+        [value]="newOrganization?.name"
         (ui5Change)="setOrganizationToSwitch($event)"
       >
         @for (org of organizations(); track org.name) {
@@ -31,16 +31,16 @@
         }
 
         <div slot="label" class="option">
-          <span>{{organizationToSwitchObj?.name}}</span>
-          @if(organizationToSwitchObj && !organizationToSwitchObj?.ready) {
+          <span>{{newOrganization?.name}}</span>
+          @if(newOrganization && !newOrganization?.ready) {
             <ui5-icon name="alert" design="Critical"></ui5-icon>
           }
         </div>
 
       </ui5-select>
       <ui5-button
-        [tooltip]="organizationToSwitchObj?.ready ? undefined : texts.switchOrganization.tooltip"
-        [disabled]="!organizationToSwitchObj || !organizationToSwitchObj?.ready"
+        [tooltip]="newOrganization?.ready ? undefined : texts.switchOrganization.tooltip"
+        [disabled]="!newOrganization || !newOrganization?.ready"
         design="Emphasized"
         (ui5Click)="switchOrganization()"
       >{{
@@ -58,14 +58,14 @@
         <ui5-input
           id="input-onboard"
           placeholder="{{ texts.onboardOrganization.placeholder }}"
-          [formControl]="newOrganization"
-          [valueState]="getValueState(newOrganization)"
+          [formControl]="newOrganizationControl"
+          [valueState]="getValueState(newOrganizationControl)"
         >
           <div slot="valueStateMessage">
             <a href="{{ k8sMessages.RFC_1035.href }}" target="_blank">{{ k8sMessages.RFC_1035.message }}</a>
           </div>
       </ui5-input>
-      <ui5-button [disabled]="newOrganization.invalid" design="Emphasized" (ui5Click)="onboardOrganization()">{{
+      <ui5-button [disabled]="newOrganizationControl.invalid" design="Emphasized" (ui5Click)="onboardOrganization()">{{
         texts.onboardOrganization.button
       }}</ui5-button>
     </div>

projects/wc/src/app/components/organization-management/organization-management.component.spec.ts

@@ -1,4 +1,3 @@
-import { OrganizationManagementComponent } from './organization-management.component';
 import {
   CUSTOM_ELEMENTS_SCHEMA,
   NO_ERRORS_SCHEMA,
@@ -17,6 +16,7 @@ import {
 } from '@openmfp/portal-ui-lib';
 import { ResourceService } from '@platform-mesh/portal-ui-lib/services';
 import { of, throwError } from 'rxjs';
+import { OrganizationManagementComponent } from './organization-management.component';
 
 describe('OrganizationManagementComponent', () => {
   let component: OrganizationManagementComponent;
@@ -143,7 +143,7 @@ describe('OrganizationManagementComponent', () => {
       reset: jest.fn(),
     };
     resourceServiceMock.create.mockReturnValue(of(mockResponse));
-    component.newOrganization.setValue('newOrg');
+    component.newOrganizationControl.setValue('newOrg');
     component.organizations.set([{ name: 'existingOrg', ready: false }]);
 
     component.onboardOrganization();
@@ -153,15 +153,15 @@ describe('OrganizationManagementComponent', () => {
       name: 'newOrg',
       ready: false,
     });
-    expect(component.newOrganization.value).toBe('');
+    expect(component.newOrganizationControl.value).toBe('');
     expect(luigiClientMock.uxManager().showAlert).toHaveBeenCalled();
   });
 
   it('should handle organization creation error', () => {
     resourceServiceMock.create.mockReturnValue(
       throwError(() => new Error('Creation failed')),
     );
-    component.newOrganization.setValue('newOrg');
+    component.newOrganizationControl.setValue('newOrg');
 
     component.onboardOrganization();
 

projects/wc/src/app/components/organization-management/organization-management.component.ts

@@ -72,7 +72,7 @@ export class OrganizationManagementComponent implements OnInit {
   texts: any = {};
   organizations = signal<{ name: string; ready: boolean }[]>([]);
   organizationToSwitch = signal<{ name: string; ready: boolean } | null>(null);
-  newOrganization = new FormControl('', {
+  newOrganizationControl = new FormControl('', {
     validators: [Validators.required, k8sNameValidator],
     nonNullable: true,
   });
@@ -147,7 +147,7 @@ export class OrganizationManagementComponent implements OnInit {
   onboardOrganization() {
     const resource: Resource = {
       spec: { type: 'org' },
-      metadata: { name: this.newOrganization.value },
+      metadata: { name: this.newOrganizationControl.value },
     };
     const resourceDefinition: ResourceDefinition = {
       group: 'core.platform-mesh.io',
@@ -163,10 +163,10 @@ export class OrganizationManagementComponent implements OnInit {
         next: (result) => {
           console.debug('Resource created', result);
           this.organizationToSwitch.set({
-            name: this.newOrganization.value,
+            name: this.newOrganizationControl.value,
             ready: false,
           });
-          this.newOrganization.reset();
+          this.newOrganizationControl.reset();
           this.LuigiClient()
             .uxManager()
             .showAlert({