Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not repport errors on unimplemented methods #77

Open
guignonv opened this issue Jul 10, 2023 · 1 comment
Open

Do not repport errors on unimplemented methods #77

guignonv opened this issue Jul 10, 2023 · 1 comment
Assignees

Comments

@guignonv
Copy link
Member

I'll try to make it short...

If you use the call https://www.crop-diversity.org/mgis5/brapi/v2/serverinfo, you'll notice the 'germplasm' call does only implement the "GET" method.

{
    "contentTypes": ["application\/json"],
    "dataTypes": ["application\/json"],
    "methods": ["GET"],
    "service": "germplasm",
    "versions": ["2.1"]
}

However, BRAVA will try and test the germplasm call with the "POST" and "PUT" method since they are part of the call definition.
image

Since my implementation is not supposed to support those methods, it will return a 501 "not implemented" while in the BrAPI specifications, only 200, 400, 401 and 403 codes are allowed.

In my opinion, BRAVA should only test methods that are declared available from the /serverinfo call.

@guignonv guignonv added the bug label Jul 10, 2023
@langeipk langeipk added enhancement and removed bug labels Jul 10, 2023
@langeipk
Copy link
Collaborator

Dear @guignonv thankf for the feature request. Indeed in a feedback with @patrick-koenig we see the benifit, if only the implemented calls are tested. It not task of the Validator to check the level of implementation of the BrAPI specs for particular service provider.
Because the toll is currently re-engineered under lead of @daveneti, in branch https://github.com/plantbreeding/IPK-BrAPI-Validator/tree/BRAVA-2-main, I assign the issue to him.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants