Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Sample to allow sub-sampling and bulked samples #573

Open
daveneti opened this issue Jul 6, 2023 · 1 comment
Open

Update Sample to allow sub-sampling and bulked samples #573

daveneti opened this issue Jul 6, 2023 · 1 comment
Labels
BrAPI-Genotyping Related to BrAPI-Genotyping Modify Data Model Change an existing data model New Parameter Adding a new search/filter parameter

Comments

@daveneti
Copy link

daveneti commented Jul 6, 2023

Use Cases

  1. Take a sub-sample from another sample. This can occur in several cases, for example extracting DNA from a plant leaf tissue or making an aliquot of the sample.
  2. Combining two or more samples into one bulked sample, for example for bulked analysis.

Proposed model changes

  • Add the property sourceSamples to the Sample entity. The new property would have array of SampleMixture.
  • A SampleMixture has the properties sampleDbId which will be the sampleDbId of the source sample and mixturePercentage which has type number, and is the relative contribution of the source sample to this sample.

Implementation by use case

  1. The sub-sample would have a single element in the sourceSamples property, which have a mixturePercentage of 100.0 and the sampleDbId of the sample from which this sub-sample was taken. The germplasm of the sub-sample will be the same as the source sample.
  2. The bulked sample would have two more elements in the sourceSampleDbIds property, which will have as mixturePercentages the relative contribution of the source sample to this sample and sampleDbId of the samples which were using the bulk. If the source samples are all from the same germplasm then this will be germplasm of the sample. If the germplasm are different, then the germplasm of this sample would need to be a new germplasm formed by the combination of all the district germplasm though a maintenance breeding method.
@BrapiCoordinatorSelby BrapiCoordinatorSelby added New Parameter Adding a new search/filter parameter Modify Data Model Change an existing data model BrAPI-Genotyping Related to BrAPI-Genotyping labels Jul 10, 2023
@ggeurts
Copy link

ggeurts commented Aug 4, 2023

Wouldn't a subsample just have the source sample as observation unit?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BrAPI-Genotyping Related to BrAPI-Genotyping Modify Data Model Change an existing data model New Parameter Adding a new search/filter parameter
Projects
None yet
Development

No branches or pull requests

3 participants