Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: mismatching version in description / yarn.lock / title #26

Closed
danielma opened this issue Sep 23, 2024 · 1 comment · Fixed by #31
Closed

Bug: mismatching version in description / yarn.lock / title #26

danielma opened this issue Sep 23, 2024 · 1 comment · Fixed by #31

Comments

@danielma
Copy link
Member

CleanShot 2024-09-23 at 15 52 46@2x

This PR upgrades add-ons to 5.4.0 and says that in the title, but the description says it's upgrading to both 5.9.0 and 5.4.0. I have done no research at this time to understand how or why this happened. I am only logging that it appears to be a bug

https://github.com/planningcenter/topbar/pull/440

@kylemellander
Copy link
Collaborator

So, in researching this, I was able to discover that v5.4.0 was the last version of add-ons that allowed for tapestry-react <4.3.1 as a peerDependency. Since topbar had the requirement of tapestry-react at ^4.3.0, this did not satisfy the requirement and thus the newer versions were found to not be 100% compatible.

The specific example fix here is to raise the requirement in topbar for tapestry-react, but I think there is a reason to raise an error if the updating version does not match the desired version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants