Skip to content

Add a way to remove specific feeds with all associated data #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
boreq opened this issue Sep 5, 2022 · 1 comment · Fixed by #46
Closed

Add a way to remove specific feeds with all associated data #39

boreq opened this issue Sep 5, 2022 · 1 comment · Fixed by #46
Assignees
Labels
enhancement New feature or request

Comments

@boreq
Copy link
Contributor

boreq commented Sep 5, 2022

We need a mechanism for removing a specific feed with all associated data. This may for example include:

  • blobs (if no other feeds reference them/the temporary on-demand want list doesn't reference them)
  • contacts
  • pubs
  • etc

This is needed for #16 and more importantly #20. I am creating this issue to distinguish between adding a way to drop a feed and implementing the slightly more complicated case of cleaning up feeds described in #16.

@boreq boreq added the enhancement New feature or request label Sep 5, 2022
@boreq boreq added this to the Needed by Planetary milestone Sep 5, 2022
@boreq boreq self-assigned this Sep 5, 2022
@boreq boreq moved this to In Progress in Verse: Nos Projects Sep 6, 2022
@boreq boreq linked a pull request Sep 9, 2022 that will close this issue
@boreq
Copy link
Contributor Author

boreq commented Sep 9, 2022

This may be problematic after #33 is added as other clients may not understand that the local sequence goes back to zero - I think the JS code specifically doesn't accept that number going down for some reason.

@boreq boreq moved this from In Progress to Code review in Verse: Nos Projects Sep 12, 2022
@boreq boreq closed this as completed in #46 Sep 13, 2022
Repository owner moved this from Review to Done in Verse: Nos Projects Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant