Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tech Debt: Prevent go-ssb from locking when connecting to pubs #301

Closed
mplorentz opened this issue Jan 25, 2022 · 2 comments
Closed

Tech Debt: Prevent go-ssb from locking when connecting to pubs #301

mplorentz opened this issue Jan 25, 2022 · 2 comments
Assignees
@boreq
Labels
bug Something isn't working go-ssb Things that relate to go-ssb in any way.
Milestone
Release 2.0.0

Comments

@mplorentz
Copy link
Member

This is a placeholder so we don't forget to file this in the appropriate go-ssb repo in the future.

The go-ssb library locks itself and won't respond to other procedure calls while attempting to establish a TCP connection to a pub server to redeem an invitation. More details in #272.
@mplorentz mplorentz mentioned this issue Jan 25, 2022
Closed
@mplorentz mplorentz self-assigned this Jan 31, 2022
@mplorentz mplorentz assigned boreq and unassigned mplorentz Feb 11, 2022
@mplorentz mplorentz added the tech A label for technical debt or technology upgrades. label Feb 11, 2022
@setch-l setch-l changed the title Prevent go-ssb from locking when connecting to pubs Tech Debt: Prevent go-ssb from locking when connecting to pubs Feb 24, 2022
@setch-l setch-l moved this to Backlog in Verse: Nos Projects Feb 24, 2022
@boreq boreq removed the tech A label for technical debt or technology upgrades. label May 16, 2022
@rabble
Copy link
Contributor

rabble commented Aug 18, 2022

shouldn't be an issue in scuttlego.

We should remove the dumb workaround we created in swift after we switch from go-ssb to scuttlego.

@danlatorre danlatorre moved this from Delivery Backlog to Design Validation Experiments in Verse: Nos Projects Dec 16, 2022
@danlatorre danlatorre moved this from Design Validation Experiments to Delivery Backlog in Verse: Nos Projects Dec 19, 2022
@boreq boreq added the go-ssb Things that relate to go-ssb in any way. label Mar 3, 2023
@boreq boreq added this to the Release 2.0.0 milestone Mar 3, 2023
@boreq boreq added the bug Something isn't working label Mar 3, 2023
@boreq boreq mentioned this issue Mar 3, 2023
Open
@boreq
Copy link
Contributor

boreq commented Mar 3, 2023

This is definitely not an issue in scuttlego however the calls to Connect are blocking and will block until connection succeeds. If we want to change that because swift is not happy about it then we need a separate ticket.

@boreq boreq closed this as completed Mar 3, 2023
@github-project-automation github-project-automation bot moved this from Delivery Backlog to Done in Verse: Nos Projects Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@boreq boreq

Labels
bug Something isn't working go-ssb Things that relate to go-ssb in any way.
Projects
Verse: Nos Projects
Archived in project
Milestone
Release 2.0.0
Development

No branches or pull requests
3 participants
@rabble @mplorentz @boreq