Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New message pill is a zombie... you tap it, it goes away, and it comes back after a minute or two #1175

Closed
boreq opened this issue Feb 20, 2023 · 3 comments
Labels
2.0 bug Something isn't working
Milestone

Comments

@boreq
Copy link
Contributor

boreq commented Feb 20, 2023

One thing i'm noticing with 402... is it keeps repeating the '26 new messages' pill

We recently fixed the new messages pill in #1086 but apparently now it works too well and permanently shows up at the top of the screen.

Screenshot 2023-02-21 at 8 19 12 AM

@boreq boreq added bug Something isn't working 2.0 labels Feb 20, 2023
@boreq boreq added this to the Scuttlego milestone Feb 20, 2023
@rabble rabble changed the title New message pill doesn't go away New message pill is a zombie... you tap it, it goes away, and it comes back after a minute or two Feb 20, 2023
@boreq boreq moved this to Development Todo in Verse: Nos Projects Feb 22, 2023
@martindsq
Copy link
Member

I cannot say for sure that this is the cause, but I found that the algorithm to fetch the messages to show only fetches follows whereas the algorithm that count the number of messages since the one at the top fetches follows and unfollows. So, if someone unfollowed 26 people after the last one you have, it will shiow 26 but no messages will be displayed.

Is this behavior of the new message pill consistent, or it is something you saw once?

@martindsq
Copy link
Member

Test again after fixing #1218

@martindsq martindsq moved this from Blocked to Design Hypotheses in Verse: Nos Projects Mar 4, 2023
@martindsq martindsq moved this from Design Hypotheses to Blocked in Verse: Nos Projects Mar 4, 2023
@boreq boreq moved this from Blocked to Development Todo in Verse: Nos Projects Mar 5, 2023
@martindsq martindsq moved this from Development Todo to Blocked in Verse: Nos Projects Mar 6, 2023
@boreq
Copy link
Contributor Author

boreq commented Mar 6, 2023

Is this still blocked? We fixed #1218.

@boreq boreq modified the milestones: Release 2.0.0, Release 2.0.1 Mar 7, 2023
@github-project-automation github-project-automation bot moved this from Blocked to Done in Verse: Nos Projects Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.0 bug Something isn't working
Projects
Archived in project
Development

No branches or pull requests

2 participants