Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename FeedStrategy and its subclasses #1072

Open
martindsq opened this issue Jan 4, 2023 · 0 comments
Open

Rename FeedStrategy and its subclasses #1072

martindsq opened this issue Jan 4, 2023 · 0 comments
Labels
tech A label for technical debt or technology upgrades.

Comments

@martindsq
Copy link
Member

We have a FeedStrategy protocol that define functions and implement a collection of classes named Algorithms. Having two names is confusing, so lets stick with one of them. The pattern is named Strategy so we can use that, however @rabble mentioned that Algorithm feels more natural to him.

Also, this would be a nice time to check the functions defined as we have evolved to use swiftui and don't need some of them, counting the total number of items comes to my mind. Also, using the user id instead of user identity (like NoHopAlgorithm does) can be faster but seems less intuitive to use and not all algorithms use it, so we can get rid of that at the protocol level.

@boreq boreq added the tech A label for technical debt or technology upgrades. label Mar 3, 2023
@rabble rabble moved this to Someday/Maybe in Verse: Nos Projects Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tech A label for technical debt or technology upgrades.
Projects
Archived in project
Development

No branches or pull requests

2 participants