Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Combine messagekeys table with messages #1027

Open
mplorentz opened this issue Dec 13, 2022 · 1 comment
Open

Combine messagekeys table with messages #1027

mplorentz opened this issue Dec 13, 2022 · 1 comment
Labels
tech A label for technical debt or technology upgrades.

Comments

@mplorentz
Copy link
Member

Every row in the messages SQL table has a 1-to-1 relationship with a row in the messagekeys table. This means we have to write a lot of extra code any time we want to read a message key, and it incurs a (small) performance cost on almost every query at runtime. We should write a database migration to combine these two tables.
@mplorentz mplorentz converted this from a draft issue Dec 13, 2022
@mplorentz mplorentz added the tech A label for technical debt or technology upgrades. label Dec 13, 2022
@mplorentz
Copy link
Member Author

This will be much cheaper to do if it is done after #1026

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tech A label for technical debt or technology upgrades.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mplorentz