-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
golang 1.21 support #82
Comments
Your init implementation in master needs a depth first recursion or other graph traversal to init all dependencies in the right order and should also skip dependent tasks which have no functions. The current implementation doesn’t guarantee the correct ordering and can throw due to the lack of these checks. Also you need to escape the package path using |
You also need to handle |
I think golang's linker just wants to reorder the initialization of all libraries according to their dependencies. |
ok, thanks for your informations. |
That's not true (and your implementation demonstrably fails in my tests).
Also what I said about nfncs of dependencies being 0 making the runtime throw still hold. For a reproducible example, check out my 1.21 WIP branch eh-steve#19 and try changing the init implementation and running the TestK8s test. You can also look at |
golang 1.21 already rc2, need adapter it
The text was updated successfully, but these errors were encountered: