Skip to content

Commit c591bcd

Browse files
raymondfengpktippa
authored andcommitted
feat: mark Entity and Model to be regular classes
The Model/Entity being abstract caused compilation errors as TS 4.2 reinforces abstract checks. https://devblogs.microsoft.com/typescript/announcing-typescript-4-2/ microsoft/TypeScript#36392 Signed-off-by: Raymond Feng <[email protected]>
1 parent 3a1c4fc commit c591bcd

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

packages/repository/src/model.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -309,7 +309,7 @@ function asObject(value: any, options?: Options): any {
309309
/**
310310
* Base class for models
311311
*/
312-
export abstract class Model {
312+
export class Model {
313313
static get modelName(): string {
314314
return this.definition?.name || this.name;
315315
}
@@ -418,7 +418,7 @@ export abstract class ValueObject extends Model implements Persistable {}
418418
/**
419419
* Base class for entities which have unique ids
420420
*/
421-
export abstract class Entity extends Model implements Persistable {
421+
export class Entity extends Model implements Persistable {
422422
/**
423423
* Get the names of identity properties (primary keys).
424424
*/

0 commit comments

Comments
 (0)