pkp/pkp-lib#11138 Fix out of date function calls

Author: asmecher

classes/payment/ojs/OJSPaymentManager.php

@@ -233,7 +233,7 @@ public function fulfillQueuedPayment($request, $queuedPayment, $payMethodPluginN
             switch ($queuedPayment->getType()) {
                 case self::PAYMENT_TYPE_MEMBERSHIP:
                     $user = Repo::user()->get($queuedPayment->getUserId(), true);
-                    $dateEnd = $user->getSetting('dateEndMembership', 0);
+                    $dateEnd = $user->getData('dateEndMembership', 0);
                     if (!$dateEnd) {
                         $dateEnd = 0;
                     }
@@ -245,7 +245,8 @@ public function fulfillQueuedPayment($request, $queuedPayment, $payMethodPluginN
                     }
 
                     $dateEnd = mktime(23, 59, 59, date('m', $dateEnd), date('d', $dateEnd), date('Y', $dateEnd) + 1);
-                    $user->updateSetting('dateEndMembership', $dateEnd, 'date', 0);
+                    $user->setData('dateEndMembership', $dateEnd);
+                    Repo::user()->edit($user);
                     $returner = true;
                     break;
                 case self::PAYMENT_TYPE_PURCHASE_SUBSCRIPTION:

pages/issue/IssueHandler.php

@@ -292,7 +292,7 @@ public function userCanViewGalley($request)
 
                         // If the issue galley has been purchased, then allow reader access
                         $completedPaymentDao = DAORegistry::getDAO('OJSCompletedPaymentDAO'); /** @var OJSCompletedPaymentDAO $completedPaymentDao */
-                        $dateEndMembership = $user->getSetting('dateEndMembership', 0);
+                        $dateEndMembership = $user->getData('dateEndMembership', 0);
                         if ($completedPaymentDao->hasPaidPurchaseIssue($userId, $issue->getId()) || (!is_null($dateEndMembership) && $dateEndMembership > time())) {
                             return true;
                         } else {