pkp/pkp-lib#10766 Remove old workflow code

Author: asmecher

controllers/tab/workflow/ReviewRoundTabHandler.php

@@ -18,31 +18,14 @@
 
 use APP\components\forms\publication\PublishForm;
 use APP\core\Application;
-use APP\decision\types\Accept;
-use APP\decision\types\SkipExternalReview;
 use APP\facades\Repo;
 use APP\file\PublicFileManager;
 use APP\publication\Publication;
-use APP\submission\Submission;
 use APP\template\TemplateManager;
 use PKP\components\forms\publication\TitleAbstractForm;
 use PKP\context\Context;
-use PKP\decision\types\BackFromCopyediting;
-use PKP\decision\types\BackFromProduction;
-use PKP\decision\types\CancelReviewRound;
-use PKP\decision\types\Decline;
-use PKP\decision\types\InitialDecline;
-use PKP\decision\types\RecommendAccept;
-use PKP\decision\types\RecommendDecline;
-use PKP\decision\types\RecommendRevisions;
-use PKP\decision\types\RequestRevisions;
-use PKP\decision\types\RevertDecline;
-use PKP\decision\types\RevertInitialDecline;
-use PKP\decision\types\SendExternalReview;
-use PKP\decision\types\SendToProduction;
 use PKP\notification\Notification;
 use PKP\pages\workflow\PKPWorkflowHandler;
-use PKP\plugins\Hook;
 use PKP\security\Role;
 
 class WorkflowHandler extends PKPWorkflowHandler
@@ -58,12 +41,9 @@ public function __construct()
             [Role::ROLE_ID_SUB_EDITOR, Role::ROLE_ID_MANAGER, Role::ROLE_ID_SITE_ADMIN, Role::ROLE_ID_ASSISTANT],
             [
                 'access', 'index', 'submission',
-                'editorDecisionActions', // Submission & review
                 'externalReview', // review
                 'editorial',
                 'production',
-                'submissionHeader',
-                'submissionProgressBar',
             ]
         );
     }
@@ -211,113 +191,6 @@ protected function getEditorAssignmentNotificationTypeByStageId($stageId)
         return null;
     }
 
-    protected function _getRepresentationsGridUrl($request, $submission)
-    {
-        return $request->getDispatcher()->url(
-            $request,
-            Application::ROUTE_COMPONENT,
-            null,
-            'grid.articleGalleys.ArticleGalleyGridHandler',
-            'fetchGrid',
-            null,
-            [
-                'submissionId' => $submission->getId(),
-                'publicationId' => '__publicationId__',
-            ]
-        );
-    }
-
-    protected function getStageDecisionTypes(int $stageId): array
-    {
-        $submission = $this->getAuthorizedContextObject(Application::ASSOC_TYPE_SUBMISSION);
-        $request = Application::get()->getRequest();
-        $reviewRoundId = (int) $request->getUserVar('reviewRoundId');
-
-        switch ($stageId) {
-            case WORKFLOW_STAGE_ID_SUBMISSION:
-                $decisionTypes = [
-                    new SendExternalReview(),
-                    new SkipExternalReview(),
-                ];
-                if ($submission->getData('status') === Submission::STATUS_DECLINED) {
-                    $decisionTypes[] = new RevertInitialDecline();
-                } elseif ($submission->getData('status') === Submission::STATUS_QUEUED) {
-                    $decisionTypes[] = new InitialDecline();
-                }
-                break;
-            case WORKFLOW_STAGE_ID_EXTERNAL_REVIEW:
-                $decisionTypes = [
-                    new RequestRevisions(),
-                    new Accept(),
-                ];
-                $cancelReviewRound = new CancelReviewRound();
-                if ($cancelReviewRound->canRetract($submission, $reviewRoundId)) {
-                    $decisionTypes[] = $cancelReviewRound;
-                }
-                if ($submission->getData('status') === Submission::STATUS_DECLINED) {
-                    $decisionTypes[] = new RevertDecline();
-                } elseif ($submission->getData('status') === Submission::STATUS_QUEUED) {
-                    $decisionTypes[] = new Decline();
-                }
-                break;
-            case WORKFLOW_STAGE_ID_EDITING:
-                $decisionTypes = [
-                    new SendToProduction(),
-                    new BackFromCopyediting(),
-                ];
-                break;
-            case WORKFLOW_STAGE_ID_PRODUCTION:
-                $decisionTypes = [
-                    new BackFromProduction(),
-                ];
-                break;
-        }
-
-        Hook::call('Workflow::Decisions', [&$decisionTypes, $stageId]);
-
-        return $decisionTypes;
-    }
-
-    protected function getStageRecommendationTypes(int $stageId): array
-    {
-        switch ($stageId) {
-            case WORKFLOW_STAGE_ID_EXTERNAL_REVIEW:
-                $decisionTypes = [
-                    new RecommendRevisions(),
-                    new RecommendAccept(),
-                    new RecommendDecline(),
-                ];
-                break;
-            default:
-                $decisionTypes = [];
-        }
-
-
-        Hook::call('Workflow::Recommendations', [$decisionTypes, $stageId]);
-
-        return $decisionTypes;
-    }
-
-    protected function getPrimaryDecisionTypes(): array
-    {
-        return [
-            SendExternalReview::class,
-            Accept::class,
-            SendToProduction::class,
-        ];
-    }
-
-    protected function getWarnableDecisionTypes(): array
-    {
-        return [
-            InitialDecline::class,
-            Decline::class,
-            CancelReviewRound::class,
-            BackFromCopyediting::class,
-            BackFromProduction::class,
-        ];
-    }
-
     protected function getTitleAbstractForm(string $latestPublicationApiUrl, array $locales, Publication $latestPublication, Context $context): TitleAbstractForm
     {
         $section = Repo::section()->get($latestPublication->getData('sectionId'), $context->getId());

controllers/tab/workflow/WorkflowTabHandler.php

@@ -24,7 +24,5 @@
     case 'externalReview':
     case 'editorial':
     case 'production':
-    case 'editorDecisionActions':
-    case 'submissionProgressBar':
         return new APP\pages\workflow\WorkflowHandler();
 }

pages/workflow/WorkflowHandler.php

@@ -91,12 +91,10 @@ lib/pkp/js/controllers/grid/representations/form/RepresentationFormHandler.js
 lib/pkp/js/controllers/grid/settings/user/form/UserDetailsFormHandler.js
 lib/pkp/js/controllers/grid/settings/roles/form/UserGroupFormHandler.js
 lib/pkp/js/controllers/grid/notifications/NotificationsGridHandler.js
-lib/pkp/js/controllers/tab/workflow/WorkflowTabHandler.js
 lib/pkp/js/controllers/informationCenter/NotesHandler.js
 lib/pkp/js/controllers/dashboard/form/DashboardTaskFormHandler.js
 lib/pkp/js/pages/header/HeaderHandler.js
 lib/pkp/js/pages/header/TasksHandler.js
-lib/pkp/js/pages/workflow/WorkflowHandler.js
 lib/pkp/js/controllers/grid/users/UserGridHandler.js
 lib/pkp/js/controllers/grid/users/reviewer/AdvancedReviewerSearchHandler.js
 lib/pkp/js/controllers/grid/users/reviewer/form/EditReviewFormHandler.js