bring back rudimentary linting of @pkmn/sim

Author: scheibo

import

@@ -442,6 +442,7 @@ const FRAGILE = new Set([
 // because they only exist in the generated package
 const OVERRIDDEN = new Set([
   ...Array.from(FRAGILE).slice(5), // most sim/dex-*.ts have *not* been overridden
+  '.eslintcache',
   '.tsbuildinfo',
   'config/formats.ts',
   'data/index.ts',
@@ -464,6 +465,7 @@ const OVERRIDDEN = new Set([
   'data/mods/gen2/legality.ts',
   'data/mods/gen6/legality.ts',
   'data/mods/gen8/legality.ts',
+  'eslint.config.mjs',
   'lib/index.ts',
   'lib/streams.ts',
   'package-lock.json', // double sigh...
@@ -690,6 +692,7 @@ const changes = async (where, last, now, repo) => ({
         let rewritten = REWRITES[file]
           ? rewrite(original, line => line in REWRITES[file] ? REWRITES[file][line] : line)
           : original;
+        rewritten = rewritten.replaceAll(/\n[^\n]*@typescript-eslint\/ban-types[^\n]*/g, '');
         if (file.startsWith('sim/dex-')) {
           rewritten = rewritten.replaceAll(/Object.freeze\((.*)\)/g, (_, $1) => $1);
         }

sim/eslint.config.mjs

@@ -0,0 +1,40 @@
+import pkmn from "@pkmn/eslint-config";
+
+export default [...pkmn, {
+  ignores: ["eslint.config.mjs", "build"],
+}, {
+  rules: {
+    "@stylistic/array-bracket-spacing": "off",
+    "@stylistic/comma-dangle": "off",
+    "@stylistic/indent": "off",
+    "@stylistic/key-spacing": "off",
+    "@stylistic/member-delimiter-style": "off",
+    "@stylistic/no-mixed-spaces-and-tabs": "off",
+    "@stylistic/no-multi-spaces": "off",
+    "@stylistic/no-multiple-empty-lines": "off",
+    "@stylistic/object-curly-spacing": "off",
+    "@stylistic/operator-linebreak": "off",
+    "@stylistic/quotes": "off",
+    "@stylistic/spaced-comment": "off",
+    "@typescript-eslint/no-base-to-string": "off",
+    "@typescript-eslint/no-floating-promises": "off",
+    "@typescript-eslint/no-redundant-type-constituents": "off",
+    "@typescript-eslint/no-this-alias": "off",
+    "@typescript-eslint/no-unnecessary-type-assertion": "off",
+    "@typescript-eslint/no-unsafe-function-type": "off",
+    "@typescript-eslint/no-unused-vars": "off",
+    "@typescript-eslint/prefer-optional-chain": "off",
+    "@typescript-eslint/restrict-template-expressions": "off",
+    "@typescript-eslint/return-await": "off",
+    "@typescript-eslint/unbound-method": "off",
+    "import/order": "off",
+    "max-len": "off",
+    "no-case-declarations": "off",
+    "no-constant-binary-expression": "off",
+    "no-shadow": "off",
+    "no-undef": "off",
+    "no-unused-vars": "off",
+    "no-var": "off",
+    "sort-imports": "off",
+  }
+}];

sim/package.json

@@ -42,7 +42,9 @@
     "compile": "tsc -p .",
     "build": "node ../build",
     "test": "mocha test/main.js test/sim/*.js test/sim/**/*.js -R dot -u bdd --exit",
+    "lint": "eslint --quiet --cache",
     "prepare": "npm run build",
-    "pretest": "node ../build --cjs"
+    "pretest": "node ../build --cjs",
+    "posttest": "npm run lint"
   }
 }

sim/sim/battle.ts

@@ -99,10 +99,8 @@ interface EventListenerWithoutPriority {
 	effect: Effect;
 	target?: Pokemon;
 	index?: number;
-	// eslint-disable-next-line @typescript-eslint/ban-types
 	callback?: Function;
 	state: EffectState | null;
-	// eslint-disable-next-line @typescript-eslint/ban-types
 	end: Function | null;
 	endCallArgs?: any[];
 	effectHolder: Pokemon | Side | Field | Battle;
@@ -2965,13 +2963,11 @@ export class Battle {
 		this.addSplit(side!, secret, shared);
 	}
 
-	// eslint-disable-next-line @typescript-eslint/ban-types
 	addMove(...args: (string | number | Function | AnyObject)[]) {
 		this.lastMoveLine = this.log.length;
 		this.log.push(`|${args.join('|')}`);
 	}
 
-	// eslint-disable-next-line @typescript-eslint/ban-types
 	attrLastMove(...args: (string | number | Function | AnyObject)[]) {
 		if (this.lastMoveLine < 0) return;
 		if (this.log[this.lastMoveLine].startsWith('|-anim|')) {

sim/sim/dex-formats.ts

@@ -501,7 +501,6 @@ export class Format extends BasicEffect implements Readonly<BasicEffect> {
 
 	constructor(data: AnyObject) {
 		super(data);
-		// eslint-disable-next-line @typescript-eslint/no-this-alias
 		data = this;
 
 		this.mod = Utils.getString(data.mod) || DEFAULT_MOD;

sim/sim/dex-species.ts

@@ -301,7 +301,6 @@ export class Species extends BasicEffect implements Readonly<BasicEffect & Speci
 
 	constructor(data: AnyObject) {
 		super(data);
-		// eslint-disable-next-line @typescript-eslint/no-this-alias
 		data = this;
 
 		this.fullname = `pokemon: ${data.name}`;

sim/sim/dex.ts

@@ -129,15 +129,13 @@ const TEXT = {
 	Default: DefaultText as DexTable<AnyObject>,
 };
 
-/* eslint-disable @typescript-eslint/array-type */
 type DeepPartial<T> = {
 	[P in keyof T]?: T[P] extends Array<infer U>
 		? Array<DeepPartial<U>>
 		: T[P] extends ReadonlyArray<infer V>
 			? ReadonlyArray<DeepPartial<V>>
 			: DeepPartial<T[P]>
 };
-/* eslint-enable @typescript-eslint/array-type */
 
 export type ModData = DeepPartial<ModdedDex['data']>;
 

sim/sim/side.ts

@@ -392,7 +392,6 @@ export class Side {
 		return true;
 	}
 
-	// eslint-disable-next-line @typescript-eslint/ban-types
 	send(...parts: (string | number | Function | AnyObject)[]) {
 		const sideUpdate = '|' + parts.map(part => {
 			if (typeof part !== 'function') return part;

sim/sim/state.ts

@@ -66,7 +66,6 @@ export const State = new class {
 	// due to circular module dependencies on Battle and Field instead
 	// of simply initializing it as a const. See isReferable for where this
 	// gets lazily created on demand.
-	// eslint-disable-next-line @typescript-eslint/ban-types
 	REFERABLE?: Set<Function>;
 
 	serializeBattle(battle: Battle): /* Battle */ AnyObject {

sim/sim/teams.ts

@@ -14,7 +14,6 @@ interface TeamGeneratorFactory {
 	getTeamGenerator(format: Format | string, seed?: PRNG | PRNGSeed | null): TeamGenerator;
 }
 
-// eslint-disable-next-line no-var
 var teamGeneratorFactory: TeamGeneratorFactory | undefined;
 
 export const Teams = new class Teams {

sim/sim/tools/exhaustive-runner.ts

@@ -109,7 +109,6 @@ export class ExhaustiveRunner {
 		const log = console.log;
 		const error = console.error;
 		try {
-			// eslint-disable-next-line @typescript-eslint/no-this-alias
 			const self = this;
 			console.log = (...s) => {
 				self.maybeClear();

sim/tsconfig.json

@@ -13,5 +13,5 @@
     "noImplicitReturns": false,
     "tsBuildInfoFile": ".tsbuildinfo"
   },
-  "exclude": ["test", "build"]
+  "exclude": ["eslint.config.mjs", "test", "build"]
 }