Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix pantry not found on install and uninstall commands #1067

Merged
merged 9 commits into from
Jan 17, 2025
Merged

Fix pantry not found on install and uninstall commands #1067

merged 9 commits into from
Jan 17, 2025

Conversation

felipecrs
Copy link
Contributor

This fix needs pkgxdev/libpkgx#80 to be released first. Marking it as draft because of it.

Closes pkgxdev/pkgm#5.

@felipecrs felipecrs force-pushed the fix-pantry-not-found branch from 25b2c47 to 395f28b Compare January 4, 2025 16:15
@coveralls
Copy link

coveralls commented Jan 4, 2025 •
edited
Loading

Coverage Status

coverage: 92.163% (-0.2%) from 92.324%
when pulling ee8f42b on felipecrs:fix-pantry-not-found
into 7f1b557 on pkgxdev:v1/main.

@felipecrs felipecrs marked this pull request as draft January 7, 2025 22:58
@mxcl mxcl force-pushed the main branch 21 times, most recently from b806c04 to 7c34462 Compare January 14, 2025 20:26
@mxcl
Copy link
Member

mxcl commented Jan 14, 2025 •
edited
Loading

pkgx no longer installs, pkgm installs instead. Thank you and sorry!

If you want to install stubs we made a mash script where maybe this can go instead: https://github.com/pkgxdev/mash/blob/main/scripts/stub.sh

@mxcl mxcl closed this Jan 14, 2025
@felipecrs felipecrs deleted the fix-pantry-not-found branch January 14, 2025 20:46
@felipecrs
Copy link
Contributor Author

Thank you and sorry!

That's alright. It's for the best of the project. Thank you!

@felipecrs
Copy link
Contributor Author

@mxcl would you be willing to bring this back as part of a 1.x maintenance release?

It would be valuable to me, as I have not updated to v2 yet.

@felipecrs
Copy link
Contributor Author

For some reason GitHub won't allow me to restore it from the UI. Luckly, I still had it on my local. Branch restored!

@jhheider jhheider reopened this Jan 16, 2025
@jhheider jhheider changed the base branch from main to v1/main January 16, 2025 23:34
@felipecrs felipecrs force-pushed the fix-pantry-not-found branch from 26b0382 to cb784f7 Compare January 16, 2025 23:39
@felipecrs felipecrs mentioned this pull request Jan 17, 2025
Merged
@felipecrs felipecrs marked this pull request as ready for review January 17, 2025 15:09
@felipecrs felipecrs requested a review from mxcl January 17, 2025 15:09
@felipecrs
Copy link
Contributor Author

@mxcl, made one small improvement to ci (checking validity of lockfile with deno cache --frozen). Please check.

@felipecrs felipecrs force-pushed the fix-pantry-not-found branch from 2758a88 to caabc38 Compare January 17, 2025 15:12
@felipecrs felipecrs marked this pull request as draft January 17, 2025 15:13
@felipecrs
Copy link
Contributor Author

Actually, please hold on. There's something weird with the lockfile. Give me some minutes.

@felipecrs felipecrs force-pushed the fix-pantry-not-found branch from 3a73023 to 15117be Compare January 17, 2025 15:23
@felipecrs
Copy link
Contributor Author

@mxcl all good now. I can explain any change if needed.

@felipecrs felipecrs force-pushed the fix-pantry-not-found branch from 15117be to d45b7c0 Compare January 17, 2025 15:25
@felipecrs felipecrs marked this pull request as ready for review January 17, 2025 15:27
felipecrs
felipecrs commented Jan 17, 2025
View reviewed changes
deno.lock Show resolved Hide resolved
felipecrs
felipecrs commented Jan 17, 2025
View reviewed changes
deno.jsonc Show resolved Hide resolved
@mxcl mxcl merged commit e0dd9c0 into pkgxdev:v1/main Jan 17, 2025
8 checks passed
mxcl pushed a commit that referenced this pull request Jan 17, 2025
@felipecrs @mxcl
Fix pantry not found on install and uninstall commands (#1067)
7a90d32 
* Temporarily use PR libpkgx
* use libpkgx^0.20.3
* Check lockfile in CI
* Regenerated lockfile
* Fix lockfile for good
@felipecrs felipecrs deleted the fix-pantry-not-found branch January 17, 2025 21:42
@felipecrs
Copy link
Contributor Author

Thank you very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mxcl mxcl Awaiting requested review from mxcl

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pkgx uninstall fails if pantry is not downloaded yet
4 participants
@felipecrs @coveralls @mxcl @jhheider